Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra space next to centred tagline when floated #1619

Open
laurelfulford opened this issue Dec 10, 2021 · 1 comment
Open

Extra space next to centred tagline when floated #1619

laurelfulford opened this issue Dec 10, 2021 · 1 comment
Assignees
Labels
[Type] Bug Incorrect behavior or functionality

Comments

@laurelfulford
Copy link
Contributor

Moved from #1594

Ran into a weird style with Center Logo on (step 10) on non-simplified headers. With a site description, at the breakpoint between 780px and 980px, the site description ends up floating weirdly below and to the right of the logo:

image

I would expect the behavior at this breakpoint to look more like it does without Center Logo on:

image

When the logo is centred, the tagline has left and right padding, which I think is adding the extra space when it wraps to the new line.

I'll have to do some more digging, but I believe the reason it's wrapping is because the image has a max width wider than the actual image, so with AMP enabled, the amp-img area is taking up more space than the actual img does. Will confirm with some testing!

@laurelfulford laurelfulford added the [Type] Bug Incorrect behavior or functionality label Dec 10, 2021
@laurelfulford
Copy link
Contributor Author

This also seems to be caused by the centred logo having a narrower 'branding' section, even when it starts being left-aligned on smaller screens. If the branding section was wider, like it is when the logo is left aligned, there should be more space for the tagline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Incorrect behavior or functionality
Projects
None yet
Development

No branches or pull requests

1 participant