Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Square-shaped logos appear to be 'floating' in some cases with AMP enabled #1618

Closed
laurelfulford opened this issue Dec 10, 2021 · 2 comments · Fixed by #1747
Closed

Square-shaped logos appear to be 'floating' in some cases with AMP enabled #1618

laurelfulford opened this issue Dec 10, 2021 · 2 comments · Fixed by #1747

Comments

@laurelfulford
Copy link
Contributor

Moved from #1594:

I also notice that on the homepage at the smallest breakpoint, my default/square logo seems to have a bit of extra side padding that doesn't appear at other breakpoints (this seems to happen any combination of header/logo settings). This also happens with the subpage header but only on AMP pages:

image

AMP sets images to object-fit: contain; if the image has a max-width that's wider than the actual image, you can get this effect of the image floating in the middle of the space. I'm fairly confident this is what's happening here -- it could just be that we need to adjust the logo sizing, or add an object-position when the image should be flush left (it doesn't work when there should be something next to the image, since the image "space" is still there, but for mobile-only it could be the best bet!).

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.57.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.57.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants