From 6ec34eed785a73b0f621120a029e56a8f38f74f7 Mon Sep 17 00:00:00 2001 From: Miguel Peixe Date: Mon, 18 Nov 2024 09:23:35 -0300 Subject: [PATCH 1/5] fix: hide cpt from menu (#1365) --- includes/class-newspack-popups.php | 1 + 1 file changed, 1 insertion(+) diff --git a/includes/class-newspack-popups.php b/includes/class-newspack-popups.php index 4a574b59..196842be 100644 --- a/includes/class-newspack-popups.php +++ b/includes/class-newspack-popups.php @@ -161,6 +161,7 @@ public static function register_cpt() { $cpt_args = [ 'labels' => $labels, 'public' => false, + 'show_in_menu' => false, 'show_ui' => true, 'show_in_rest' => true, 'supports' => [ 'editor', 'title', 'custom-fields', 'thumbnail', 'revisions' ], From e1b096b900a012910b395db976eb463a377f56e8 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 18 Nov 2024 16:46:41 +0000 Subject: [PATCH 2/5] chore(deps): bump qs from 6.13.0 to 6.13.1 Bumps [qs](https://github.com/ljharb/qs) from 6.13.0 to 6.13.1. - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](https://github.com/ljharb/qs/compare/v6.13.0...v6.13.1) --- updated-dependencies: - dependency-name: qs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- package-lock.json | 8 ++++---- package.json | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package-lock.json b/package-lock.json index 2bdaaca3..1426c79c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -12,7 +12,7 @@ "intersection-observer": "^0.12.2", "js-cookie": "^3.0.5", "newspack-components": "^3.1.0", - "qs": "^6.13.0" + "qs": "^6.13.1" }, "devDependencies": { "@rushstack/eslint-patch": "^1.10.4", @@ -23782,9 +23782,9 @@ } }, "node_modules/qs": { - "version": "6.13.0", - "resolved": "https://registry.npmjs.org/qs/-/qs-6.13.0.tgz", - "integrity": "sha512-+38qI9SOr8tfZ4QmJNplMUxqjbe7LKvvZgWdExBOmd+egZTtjLB67Gu0HRX3u/XOq7UU2Nx6nsjvS16Z9uwfpg==", + "version": "6.13.1", + "resolved": "https://registry.npmjs.org/qs/-/qs-6.13.1.tgz", + "integrity": "sha512-EJPeIn0CYrGu+hli1xilKAPXODtJ12T0sP63Ijx2/khC2JtuaN3JyNIpvmnkmaEtha9ocbG4A4cMcr+TvqvwQg==", "dependencies": { "side-channel": "^1.0.6" }, diff --git a/package.json b/package.json index c824e13c..bd46000e 100644 --- a/package.json +++ b/package.json @@ -35,7 +35,7 @@ "intersection-observer": "^0.12.2", "js-cookie": "^3.0.5", "newspack-components": "^3.1.0", - "qs": "^6.13.0" + "qs": "^6.13.1" }, "devDependencies": { "@rushstack/eslint-patch": "^1.10.4", From 754f78b335777af170025aea6af71d7352d69cb9 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 18 Nov 2024 16:47:25 +0000 Subject: [PATCH 3/5] chore(deps-dev): bump @wordpress/browserslist-config Bumps [@wordpress/browserslist-config](https://github.com/WordPress/gutenberg/tree/HEAD/packages/browserslist-config) from 6.11.0 to 6.12.0. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/browserslist-config/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/browserslist-config@6.12.0/packages/browserslist-config) --- updated-dependencies: - dependency-name: "@wordpress/browserslist-config" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- package-lock.json | 8 ++++---- package.json | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package-lock.json b/package-lock.json index 1426c79c..c7dd989e 100644 --- a/package-lock.json +++ b/package-lock.json @@ -16,7 +16,7 @@ }, "devDependencies": { "@rushstack/eslint-patch": "^1.10.4", - "@wordpress/browserslist-config": "^6.11.0", + "@wordpress/browserslist-config": "^6.12.0", "eslint": "^8.57.0", "lint-staged": "^15.2.10", "newspack-scripts": "^5.5.2", @@ -6712,9 +6712,9 @@ } }, "node_modules/@wordpress/browserslist-config": { - "version": "6.11.0", - "resolved": "https://registry.npmjs.org/@wordpress/browserslist-config/-/browserslist-config-6.11.0.tgz", - "integrity": "sha512-wUDbJ3x7c8iMZLtwo+7VlWZ/vDc47PDW2eSAKW18RrQBSTdaNmWi4qiyFYi7Ye2XkyfUd2gp71MTJjZi6n/V2A==", + "version": "6.12.0", + "resolved": "https://registry.npmjs.org/@wordpress/browserslist-config/-/browserslist-config-6.12.0.tgz", + "integrity": "sha512-rFsMgWpJSu6I4rgqIGr/+ofVC4hsGIpJCXorNpRX8Zdo6wZvo/jHCZfOHq1RQ0dw9kNM2Q5UE5Sve1XpsDWPXA==", "dev": true, "engines": { "node": ">=18.12.0", diff --git a/package.json b/package.json index bd46000e..348a3975 100644 --- a/package.json +++ b/package.json @@ -39,7 +39,7 @@ }, "devDependencies": { "@rushstack/eslint-patch": "^1.10.4", - "@wordpress/browserslist-config": "^6.11.0", + "@wordpress/browserslist-config": "^6.12.0", "eslint": "^8.57.0", "lint-staged": "^15.2.10", "newspack-scripts": "^5.5.2", From c35772f65b429f3fdbfc9afe7cc0166685fd7a2a Mon Sep 17 00:00:00 2001 From: Laurel Date: Mon, 18 Nov 2024 12:43:20 -0800 Subject: [PATCH 4/5] fix: prevent issue with double-scrollbars in really specific circumstances (#1370) --- src/view/style.scss | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/view/style.scss b/src/view/style.scss index f0484c99..d866db00 100644 --- a/src/view/style.scss +++ b/src/view/style.scss @@ -71,7 +71,7 @@ $width__tablet: 782px; background: white; border: none; box-shadow: 0 0 1em 0.5em rgba(black, 0.1); - overflow-x: hidden; + overflow: hidden; position: relative; transform: none; transition: transform 0.2s ease-in-out; @@ -267,7 +267,6 @@ $width__tablet: 782px; &.newspack-lightbox-placement-top_right { .newspack-popup-wrapper { max-height: calc(100% - #{$overlay__gap}); - overflow-y: auto; } } @@ -275,7 +274,6 @@ $width__tablet: 782px; &.newspack-lightbox-placement-top { .newspack-popup-wrapper { max-height: 100%; - overflow-y: auto; } } From f8e12fa99727c708ecca74d04567412bd7df05f8 Mon Sep 17 00:00:00 2001 From: leogermani Date: Tue, 19 Nov 2024 10:58:22 -0300 Subject: [PATCH 5/5] chore: remove dependabot pulls from changelog workflow (#1369) --- .github/workflows/changelog.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml index 52534ece..85f67cbd 100644 --- a/.github/workflows/changelog.yml +++ b/.github/workflows/changelog.yml @@ -5,7 +5,7 @@ on: jobs: labeler: - if: github.event.pull_request.merged == true && github.event.pull_request.base.ref == 'trunk' + if: github.event.pull_request.merged == true && github.event.pull_request.base.ref == 'trunk' && github.event.pull_request.user.login != 'dependabot[bot]' permissions: contents: read pull-requests: write @@ -14,7 +14,7 @@ jobs: - uses: actions/labeler@v5 comment_pr: - if: github.event.pull_request.merged == true && github.event.pull_request.base.ref == 'trunk' + if: github.event.pull_request.merged == true && github.event.pull_request.base.ref == 'trunk' && github.event.pull_request.user.login != 'dependabot[bot]' permissions: contents: read pull-requests: write @@ -25,7 +25,7 @@ jobs: uses: thollander/actions-comment-pull-request@v3 with: message: | - Hey @${{ github.event.pull_request.assignee.login }}, good job getting this PR merged! :tada: + Hey @${{ github.event.pull_request.user.login }}, good job getting this PR merged! :tada: Now, the `needs-changelog` label has been added to it.