General: update requirements to match upcoming WP 6.0 release #24083

jeherve · 2022-04-26T13:01:53Z

Changes proposed in this Pull Request:

Update required WordPress version to WP 6.0 -1 (5.9)
Update tested up to version to WP 6.0

Jetpack product discussion

See WordPress 6.0 compatibility #24082

Does this pull request change what data or activity we track or use?

N/A

Testing instructions:

Is CI happy?
Are the numbers correct?

See #24082

matticbot · 2022-04-26T13:02:03Z

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D79510-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

github-actions · 2022-04-26T13:03:08Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ All commits were linted before commit.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

Next scheduled release: June 7, 2022.
Scheduled code freeze: May 31, 2022.

Backup plugin:

Next scheduled release: June 7, 2022.
Scheduled code freeze: May 30, 2022.

Vaultpress plugin:

Next scheduled release: June 7, 2022.
Scheduled code freeze: May 30, 2022.

Boost plugin:

Next scheduled release: June 7, 2022.
Scheduled code freeze: May 30, 2022.

Search plugin:

Next scheduled release: May 30, 2022.
Scheduled code freeze: May 23, 2022.

Social plugin:

Next scheduled release: June 7, 2022.
Scheduled code freeze: May 30, 2022.

Starter Plugin plugin:

Next scheduled release: June 7, 2022.
Scheduled code freeze: May 30, 2022.

Protect plugin:

Next scheduled release: June 7, 2022.
Scheduled code freeze: May 30, 2022.

See https://make.wordpress.org/core/2021/11/10/default-git-branch-for-wordpress-wordpress-develop/ That means our master tests have not really been running on the latest dev version of WordPress since last november. :|

…/wp-compat-60

kraftbj · 2022-05-03T13:54:05Z

I'll work on landing 24224 right now so we can have this ready to merge at the same time as the #23908 to avoid folks having to bump their PRs too many times.

github-actions · 2022-05-03T16:00:42Z

Great news! One last step: head over to your WordPress.com diff, D79510-code, and deploy it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

* General: update requirements to match upcoming WP 6.0 release See #24082 * Update minimum version required in Jetpack * WordPress' git repos now use trunk instead of master See https://make.wordpress.org/core/2021/11/10/default-git-branch-for-wordpress-wordpress-develop/ That means our master tests have not really been running on the latest dev version of WordPress since last november. :| * Update array of valid WP branches * Update menu order id rounding See https://core.trac.wordpress.org/ticket/40927 * Set up custom stats key values in tests depending on WP version See https://core.trac.wordpress.org/ticket/40927 * Do not run failing tests on WordPress.com for now See Automattic/jetpack#24083 (comment) * Update to use ID instead of id Co-authored-by: Brandon Kraft <[email protected]> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/2264920263

jeherve · 2022-05-03T17:06:46Z

r244861-wpcom

kraftbj · 2022-05-07T04:36:58Z

Noting the id to ID changes made in this PR are no longer necessary; however, I think we should leave it.

Perk is older versions of Jetpack won't face any oddities due to the original issue. https://core.trac.wordpress.org/changeset/53362

…release (#24083) * General: update requirements to match upcoming WP 6.0 release See #24082 * Update minimum version required in Jetpack * WordPress' git repos now use trunk instead of master See https://make.wordpress.org/core/2021/11/10/default-git-branch-for-wordpress-wordpress-develop/ That means our master tests have not really been running on the latest dev version of WordPress since last november. :| * Update array of valid WP branches * Update menu order id rounding See https://core.trac.wordpress.org/ticket/40927 * Set up custom stats key values in tests depending on WP version See https://core.trac.wordpress.org/ticket/40927 * Do not run failing tests on WordPress.com for now See #24083 (comment) * Update to use ID instead of id Co-authored-by: Brandon Kraft <[email protected]>

jeherve · 2022-05-19T10:38:03Z

Cherry-picked to jetpack/branch-10.9 in a0b9931

jeherve · 2022-05-19T15:15:00Z

Packages were updated in the release branch in d800479

When WordPress core renamed their main branch from "master" to "trunk", first we didn't notice for several months. Then when we changed things over in #24083, we overlooked changing the Jetpack test-running script that was only running the multisite tests against WP "master" to run against "trunk" instead.

General: update requirements to match upcoming WP 6.0 release

6ecb0f9

See #24082

jeherve added this to the jetpack/11.0 milestone Apr 26, 2022

jeherve added General [Pri] Normal [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Apr 26, 2022

jeherve self-assigned this Apr 26, 2022

jeherve requested a review from kraftbj April 26, 2022 13:01

matticbot added the Touches WP.com Files label Apr 26, 2022

jeherve mentioned this pull request Apr 26, 2022

WordPress 6.0 compatibility #24082

Closed

6 tasks

Update minimum version required in Jetpack

ccada87

kraftbj modified the milestones: jetpack/11.0, jetpack/10.9.1 Apr 26, 2022

jeherve mentioned this pull request Apr 26, 2022

General: remove backwards compatibility code now that Jetpack requires WP 5.9 #24086

Merged

jeherve added 2 commits April 26, 2022 16:35

WordPress' git repos now use trunk instead of master

01b9f9d

See https://make.wordpress.org/core/2021/11/10/default-git-branch-for-wordpress-wordpress-develop/ That means our master tests have not really been running on the latest dev version of WordPress since last november. :|

Merge remote-tracking branch 'origin/update/wp-compat-60' into update…

03f3503

…/wp-compat-60

jeherve added [Status] In Progress and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Apr 26, 2022

Merge remote-tracking branch 'origin/master' into update/wp-compat-60

9dd87b5

jeherve dismissed kraftbj’s stale review via 9dd87b5 May 3, 2022 14:03

kraftbj previously approved these changes May 3, 2022

View reviewed changes

kraftbj added 2 commits May 3, 2022 10:23

Update to use ID instead of id

147e097

changelog

35d5f17

kraftbj dismissed their stale review via 35d5f17 May 3, 2022 15:24

github-actions bot added the [Package] Sync label May 3, 2022

Merge branch 'master' into update/wp-compat-60

8189a2e

kraftbj approved these changes May 3, 2022

View reviewed changes

kraftbj merged commit 4d0acf4 into master May 3, 2022

kraftbj deleted the update/wp-compat-60 branch May 3, 2022 15:59

jeherve removed the [Status] Blocked / Hold label May 3, 2022

bindlegirl removed the [Status] Needs Cherry-Pick label Jun 7, 2022

anomiex mentioned this pull request Jun 9, 2022

jetpack: Reenable running of multisite tests in CI #24690

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

General: update requirements to match upcoming WP 6.0 release #24083

General: update requirements to match upcoming WP 6.0 release #24083

jeherve commented Apr 26, 2022

matticbot commented Apr 26, 2022

github-actions bot commented Apr 26, 2022 •

edited

Loading

kraftbj commented May 3, 2022

github-actions bot commented May 3, 2022

jeherve commented May 3, 2022

kraftbj commented May 7, 2022

jeherve commented May 19, 2022

jeherve commented May 19, 2022

General: update requirements to match upcoming WP 6.0 release #24083

General: update requirements to match upcoming WP 6.0 release #24083

Conversation

jeherve commented Apr 26, 2022

Changes proposed in this Pull Request:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

matticbot commented Apr 26, 2022

github-actions bot commented Apr 26, 2022 • edited Loading

kraftbj commented May 3, 2022

github-actions bot commented May 3, 2022

jeherve commented May 3, 2022

kraftbj commented May 7, 2022

jeherve commented May 19, 2022

jeherve commented May 19, 2022

github-actions bot commented Apr 26, 2022 •

edited

Loading