Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget visibility: integrate with WooCommerce Shop Page #8343

Open
jesscga opened this issue Dec 10, 2017 · 14 comments
Open

Widget visibility: integrate with WooCommerce Shop Page #8343

jesscga opened this issue Dec 10, 2017 · 14 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Widget Visibility Good For Community [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@jesscga
Copy link

jesscga commented Dec 10, 2017

Steps to reproduce the issue

  1. Add widget to widget area.
  2. Under Visibility, select Show if Page is Shop

What I expected

Widget should appear on Shop page

What happened instead

Widget disappears and does not appear on any page

Workaround is using a plugin like https://wordpress.org/plugins/widget-logic/, which works as expected.

@jesscga jesscga added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Dec 10, 2017
@jesscga jesscga assigned jesscga and unassigned jesscga Dec 10, 2017
@jesscga
Copy link
Author

jesscga commented Dec 10, 2017

Reported on 834338-zen

@jeherve
Copy link
Member

jeherve commented Dec 11, 2017

What happens if you pick this option instead:

screenshot 2017-12-11 at 23 06 37

Does it work?

@jeherve jeherve added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 11, 2017
@jesscga
Copy link
Author

jesscga commented Dec 12, 2017

Yes! Setting visibility to Show if Page is Products does make the widget appear on the Shop page.

@jeherve jeherve closed this as completed Dec 12, 2017
@RonnyM82
Copy link

RonnyM82 commented Jan 2, 2018

Why has this issue been closed? Setting it to products is far too broad reaching. The only product page I want the widget to be visible on is the Shop page... not all product archive pages.

@jeherve
Copy link
Member

jeherve commented Jan 2, 2018

The only product page I want the widget to be visible on is the Shop page... not all product archive pages.

The product custom post type created by Woocommerce should have only one archive page; the Shop page. If you have other archive pages on your site, they most likely won't be affected by this rule. If you run into issues, send us some examples and we'll take a closer look.

Thanks!

@htdat
Copy link
Member

htdat commented Jun 4, 2019

2079737-zen
I think to avoid this confusion, we may silently apply the logic for product archive page if users select the shop page?

@jeherve
Copy link
Member

jeherve commented Jun 4, 2019

we may silently apply the logic for product archive page if users select the shop page?

We may give this a try, however I would be afraid of creating more confusion for folks with a "Shop" page that is not actually a Product archive page today.

@xdjxdaveyx
Copy link

I found that it will not show on category or shop pages. My way around it was to hide it on every page that I didn't want the widget on!

@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Apr 29, 2020
@samiff
Copy link
Contributor

samiff commented Jun 1, 2020

I got thrown off by this. Setting the widget visibility to also show on "Taxonomy - Product categories - All pages" I could see being desirable for some.

3025302-zen

@melek
Copy link

melek commented Aug 16, 2021

@jeherve I opened #20693 which was a duplicate of this - thanks for tracking this down, I couldn't find this report!

Since this is an old bug (4 years old!), I don't want to mess with the tags - but I do think they should be adjusted:

  • 'Need author feedback' seems a bit unlikely now, and shouldn't block fixing this issue.
  • This bug could use a priority - as I work with Woo it feels high priority, but I know I'm biased!

Want to mention that with #20057 getting worked on, it might be a convenient time to settle this one. Old bugs are all the more satisfying to squish :)

Edit: Adding that we are engaging a client who wants to use this feature (4220508-zen).

Edit: I realized this is closed (and I think maybe re-opened) - I do think that it would be less confusing, not more, for customers if the 'Shop' page they assign in WooCommerce would work with this feature. Otherwise, a 'WooCommerce Archives' option might be a worthwhile implementation for this feature when Woo is present.

Lacking that, I believe that this should be somehow covered in documentation (maybe it is?)

@jeherve jeherve added [Pri] Low Good For Community and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Aug 17, 2021
@jeherve
Copy link
Member

jeherve commented Aug 17, 2021

I do think they should be adjusted

You're right. I've adjusted things.

I believe that this should be somehow covered in documentation (maybe it is?)

It's not, and that could indeed be an option although I do not think many folks will rely on the documentation to figure out such gotchas.

@zdenys
Copy link
Contributor

zdenys commented Dec 28, 2022

Just noting that I ended up discovering the same issue Automattic/wp-calypso#71544.

As prevention, I think we should document the workaround you @jeherve mentioned above and add it both in Jetpack.com documentation and even in WordPress.com one.

If not, what could be a solution?

@github-actions
Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • 834338-zen
  • 2079737-zen
  • 3025302-zen
  • 4220508-zen

@vajrasar
Copy link

Hey all! FYI I closed Widget Visibility Rule doesn't work for WooCommerce Shop page #71544 in favor of this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Widget Visibility Good For Community [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

10 participants