Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Milestone Widget: PHP Notice in block widget management page #20208

Closed
spacedmonkey opened this issue Jun 29, 2021 · 2 comments · Fixed by #20242
Closed

Milestone Widget: PHP Notice in block widget management page #20208

spacedmonkey opened this issue Jun 29, 2021 · 2 comments · Fixed by #20242
Assignees
@jeherve
Labels
[Feature] Extra Sidebar Widgets [Type] Bug When a feature is broken and / or not performing as intended
Milestone
jetpack/9.9.1

Comments

@spacedmonkey
Copy link
Contributor

While testing the new widget editor screen found in WordPress 5.8 / gutenberg, I saw a notice error. See screenshot. See the orignal ticket WordPress/gutenberg#33056

Steps to reproduce the issue

  1. Install jetpack plugin.
  2. Activate plugin
  3. Setup wordpess.com account.
  4. Jetpack > Settings > Writing > Widgets. Enable widgets.
  5. Insert milestone (jetpack) widget.
  6. Preview widget.

What I expected

What happened instead

Screenshots
Screenshot 2021-06-28 at 23 02 10
@spacedmonkey spacedmonkey added the [Type] Bug When a feature is broken and / or not performing as intended label Jun 29, 2021
@spacedmonkey spacedmonkey mentioned this issue Jun 29, 2021
Closed
@jeherve
Copy link
Member

jeherve commented Jun 29, 2021

Thanks for the report, we'll take a look at this.

Primary issue: #19654.

@jeherve jeherve changed the title Block based widget screen error. Milestone Widget: PHP Notice in block widget management page Jun 29, 2021
@jeherve jeherve mentioned this issue Jun 29, 2021
Closed
20 tasks
@jeherve jeherve added this to the jetpack/9.9.1 milestone Jun 30, 2021
@jeherve
Copy link
Member

jeherve commented Jul 1, 2021

This appears to be a Core issue. This is currently tracked here:
https://core.trac.wordpress.org/ticket/53548

jeherve added a commit that referenced this issue Jul 1, 2021
@jeherve
Milestone widget: avoid php notices
4aa8264 
Fixes #20208

Also took the opportunity to update the date calculations to avoid a PHPCS warning from Core, thanks to the current_datetime() function that was added to WP Core in WP 5.3:
https://make.wordpress.org/core/2019/09/23/date-time-improvements-wp-5-3/
@jeherve jeherve mentioned this issue Jul 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

Labels
[Feature] Extra Sidebar Widgets [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
jetpack/9.9.1
Development

Successfully merging a pull request may close this issue.

Milestone widget: avoid php notices Automattic/jetpack
3 participants
@kraftbj @spacedmonkey @jeherve