-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header with Logo, Navigation, and Social Media Icons #212
Comments
I'm thinking if the socials and the actual nav items should have more gap between, for better visual separation. |
Same as #210 for the logo. Otherwise, this will look broken in the inserter. I'm not a big fan of the coloured social icons, especially in a header. What about making it the same as the foreground colour? |
I tried setting the gap in the nav menu, but it doesn't seem to have much effect.
Actually, when you copy-paste the code the icons are black. Not sure how that works... As for the logo, I'm not seeing a way to set a default image. I don't think it looks broken in the inserter though - you do see the placeholder. It only looks off in the preview. This one is especially affected because without the logo the nav moved to the left: If this is a deal breaker then we might want to hold off on this pattern. |
My apologies for being late in responding. I've been overwhelmed with catching stuff up in Git :)
Sorry, I realised that I didn't understand the logo while I was commenting on a similar thing in another thread 🙇🏻♂️ Ignore me, and yes, you're right. With a placeholder, it won't look broken in the inserter. |
https://dotcompatterns.wordpress.com/?p=5585&preview=true
The text was updated successfully, but these errors were encountered: