Scene Tags #1030
Merged
Scene Tags #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think
|
Looking pretty good. Adjust the name tags to look like this:
|
Dhruv-0-Arora
requested review from
a-crowell and
LucaHaverty
and removed request for
a team
Dhruv-0-Arora
added
the
ui/ux
a-crowell
previously requested changes
Jul 17, 2024
LucaHaverty
requested changes
Jul 17, 2024
There was a problem hiding this comment.
Nice work! This is looking good, just a couple comments:
For me, the tags are appearing at the bottom of robots instead of above them
Do you think you can add a toggle in the settings modal to disable nametag rendering? To do so:
- Name the preference under "GlobalPreference" in PreferenceTypes.ts and assign it a default value
- Add it to the settings modal (you can pretty much copy any other toggleable setting)
- Access it elsewhere by calling:
PreferencesSystem.getGlobalPreference<boolean>("RenderSceneTags")
Dhruv-0-Arora
commented
Jul 17, 2024
HunterBarclay
requested changes
Jul 18, 2024
Used a label for consistency Modified the WorldToPixelSpace function
HunterBarclay
approved these changes
Jul 18, 2024
LucaHaverty
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating 2D tags that will overlay on top of the scene (as they are rendered independently) and are currently used to follow around the robots on screen but they can be used for anything. Since the tags are 2D they always are facing the user.
JIRA Issue