Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs from AE Merge #32

Open
ksalyer opened this issue Apr 27, 2023 · 1 comment
Open

Bugs from AE Merge #32

ksalyer opened this issue Apr 27, 2023 · 1 comment

Comments

@ksalyer
Copy link
Contributor

ksalyer commented Apr 27, 2023

2 bugs were found, but more may become apparent when fixing these two:

  1. When running PCA training with following command:
    python scripts/train.py --input_file "tutorial/SingleMuon.parquet" --output_dir "tutorial/tutorial_addMLAlgos" --algorithm "pca" --tag "default_pca" --histograms "L1T//Run summary/L1TStage2EMTF/emtfTrackPhi,L1T//Run summary/L1TStage2EMTF/emtfTrackEta" --debug

returns the following error: pcaError.pdf

which leads to these lines in the pca algorithm:

if 'CSC' in histogram:
label_field = 'CSC_label'
elif 'emtf' in histogram:
label_field = 'EMTF_label'
else:
label_field = None

  1. When running autoencoder training with following command:
    python scripts/train.py --input_file "tutorial/tutorial_addMLAlgos/SingleMuon.parquet" --output_dir "tutorial_addMLAlgos" --algorithm "autoencoder" --tag "default_ae" --histograms "L1T//Run summary/L1TStage2EMTF/emtfTrackPhi,L1T//Run summary/L1TStage2EMTF/emtfTrackEta" --debug

returns the following error: aeError.pdf

which leads to this line in the ae algorithm:

strides = self.self.strides_1d,

@chosila
Copy link
Contributor

chosila commented Jul 7, 2023

I've reverted the PR that caused this issue #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants