Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set memory allocation to 2BG #138

Merged
merged 1 commit into from
Feb 12, 2024
Merged

fix: set memory allocation to 2BG #138

merged 1 commit into from
Feb 12, 2024

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Feb 5, 2024

Copy link

github-actions bot commented Feb 5, 2024

Visit the preview URL for this PR (updated for commit 68cd8f6):

https://astar-token-api--pr138-fix-memory-g2tajuvg.web.app

(expires Mon, 12 Feb 2024 20:22:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f99fa4f4f8f3bb450e6e842f7e1c7783d6d896a3

@gluneau gluneau requested a review from bobo-k2 February 6, 2024 02:45
@@ -20,5 +20,5 @@ app.use(cors());
const controllers: IControllerBase[] = container.getAll<IControllerBase>(ContainerTypes.Controller);
controllers.forEach((controller) => controller.register(app));

functions.runWith({ memory: '512MB' });
functions.runWith({ memory: '2GB' });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my try to set memory allocated to Firebase functions, but unfortunately this doesn't work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments in the quoted github comment says that 512MB does not work, but 2GB does.

@gluneau gluneau merged commit c63991c into prod Feb 12, 2024
5 checks passed
@gluneau gluneau deleted the fix/memory branch February 12, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants