Sending base64 images optimization

AstarNetwork · Nov 22, 2023 · 5e83b9b · 5e83b9b
1 parent ee89249
commit 5e83b9b
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 13 deletions.
diff --git a/src/controllers/DappsStakingController.ts b/src/controllers/DappsStakingController.ts
@@ -183,7 +183,11 @@ export class DappsStakingController extends ControllerBase implements IControlle
             */
 
             try {
-                const data = await this._firebaseService.getDapp(req.params.address, req.params.network as NetworkType);
+                const data = await this._firebaseService.getDapp(
+                    req.params.address,
+                    req.params.network as NetworkType,
+                    req.query.forEdit as unknown as boolean,
+                );
 
                 if (data) {
                     res.json(data);

diff --git a/src/services/FirebaseService.ts b/src/services/FirebaseService.ts
@@ -16,7 +16,7 @@ export interface Cache<T> {
 export interface IFirebaseService {
     getDappsFull(network: NetworkType): Promise<DappItem[]>;
     getDapps(network: NetworkType): Promise<DappItem[]>;
-    getDapp(address: string, network: NetworkType): Promise<NewDappItem | undefined>;
+    getDapp(address: string, network: NetworkType, forEdit: boolean): Promise<NewDappItem | undefined>;
     registerDapp(dapp: NewDappItem, network: NetworkType): Promise<DappItem>;
     updateCache<T>(key: string, item: T): Promise<void>;
     readCache<T>(key: string): Promise<Cache<T> | undefined>;
@@ -50,7 +50,7 @@ export class FirebaseService implements IFirebaseService {
         return this.getDappsData(query);
     }
 
-    public async getDapp(address: string, network: NetworkType): Promise<NewDappItem | undefined> {
+    public async getDapp(address: string, network: NetworkType, forEdit = false): Promise<NewDappItem | undefined> {
         Guard.ThrowIfUndefined('address', address);
 
         this.initApp();
@@ -66,15 +66,17 @@ export class FirebaseService implements IFirebaseService {
                 await admin.firestore().collection(collectionKey).doc(fbAddress).get()
             ).data() as unknown as NewDappItem;
 
-            const icon = await this.getFileInfo(dapp.iconUrl, collectionKey);
-            if (icon) {
-                dapp.iconFile = icon;
-            }
+            if (forEdit) {
+                const icon = await this.getFileInfo(dapp.iconUrl, collectionKey);
+                if (icon) {
+                    dapp.iconFile = icon;
+                }
 
-            const images = dapp.imagesUrl
-                ? await Promise.all(dapp.imagesUrl.map((x) => this.getFileInfo(x, collectionKey)))
-                : [];
-            dapp.images = images.filter((x) => x !== null) as FileInfo[];
+                const images = dapp.imagesUrl
+                    ? await Promise.all(dapp.imagesUrl.map((x) => this.getFileInfo(x, collectionKey)))
+                    : [];
+                dapp.images = images.filter((x) => x !== null) as FileInfo[];
+            }
 
             return dapp;
         }
@@ -109,7 +111,7 @@ export class FirebaseService implements IFirebaseService {
             imagesUrl: dapp.imagesUrl,
             developers: dapp.developers,
             description: dapp.description,
-            shortDescription: dapp.shortDescription,
+            shortDescription: dapp.shortDescription ?? '',
             communities: dapp.communities,
             contractType: dapp.contractType,
             mainCategory: dapp.mainCategory,

diff --git a/tests/services/FirebaseServiceMock.ts b/tests/services/FirebaseServiceMock.ts
@@ -15,7 +15,7 @@ export class FirebaseServiceMock implements IFirebaseService {
         throw new Error('Method not implemented.');
     }
 
-    public async getDapp(address: string, network: NetworkType): Promise<NewDappItem | undefined> {
+    public async getDapp(address: string, network: NetworkType, forEdit = false): Promise<NewDappItem | undefined> {
         throw new Error('Method not implemented.');
     }