Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/evm fee burning #1390

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix/evm fee burning #1390

wants to merge 2 commits into from

Conversation

Dinonard
Copy link
Member

Pull Request Summary

Fixes an inconsistency where EVM fees would be handled differently compared to the native fees.

This PR ensures that 80% of the fees are burned, while the tip goes 100% into the collator reward pot.

@Dinonard Dinonard added shiden related to shiden runtime astar Related to Astar shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. labels Nov 28, 2024
@Dinonard Dinonard self-assigned this Nov 28, 2024
Copy link

Code Coverage

Package Line Rate Branch Rate Health
precompiles/dapp-staking/src/test 0% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
precompiles/dispatch-lockdrop/src 86% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/dapp-staking/src 83% 0%
precompiles/unified-accounts/src 100% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
precompiles/xcm/src 71% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/collator-selection/src 92% 0%
pallets/dapp-staking/rpc/runtime-api/src 0% 0%
pallets/ethereum-checked/src 74% 0%
pallets/static-price-provider/src 85% 0%
pallets/xc-asset-config/src 50% 0%
precompiles/assets-erc20/src 78% 0%
pallets/price-aggregator/src 82% 0%
precompiles/dapp-staking/src 90% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
pallets/dapp-staking/src/benchmarking 98% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/dapp-staking/src/test 0% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
primitives/src/xcm 65% 0%
pallets/collective-proxy/src 86% 0%
pallets/unified-accounts/src 86% 0%
primitives/src 55% 0%
pallets/inflation/src 89% 0%
pallets/vesting-mbm/src 89% 0%
precompiles/sr25519/src 64% 0%
chain-extensions/pallet-assets/src 56% 0%
chain-extensions/types/assets/src 0% 0%
Summary 79% (3730 / 4747) 0% (0 / 0)

Minimum allowed line rate is 50%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant