-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AssetSync has moved / revamp #316
Comments
Thank you @davidjrice ... I'd definitely contribute to a gittip or alike to keep on supporting |
👍 happy to see this picked up 💃 |
Thanks folks :) Don’t worry. I’ll hopefully get a chance to get stuck in to some things next week.
|
@paulrnash may be interested |
What does it mean that AssetSync is "moved"? Does it mean this repo isn't the authoritative version anymore? What's the public gem version drawn from? As of this writing, the last commits to master were over a year ago, so it seems it has completely stalled. The gzip compression can be merged (or at least some feedback about it), it works and solves the problem => #310 |
Any plan on adding some collaborators? |
Yep. If anyone is volunteering! I will consider adding them. So far no-one! Sorry I still haven't got to restarting this. I'm really not sure the direction to take, I've been waiting till an opportunity to work on a project with asset_sync installed comes up to address these things as pretty much all the projects I'm working on at present, that pay the bills, do not have any assets served from rails. |
I can volunteer to review some easy to understand Pull Requests like #315 I still got to maintain I guess a "test project" should be created for debugging some issues |
Well then, just added the first contributor. Welcome @PikachuEXE Feel free to start preparing a new release in a branch if you want help reviewing. There is a test project or two somewhere for older rails versions. Plus a good bit of tests in the repo however yeah, some sort of better integration test would be good. Oh, just those pesky personal bills o.O |
Should I commit/merge things into |
Yeah. Branch would be great. I can help review then easily. Should add On Friday, 26 February 2016, PikachuEXE [email protected] wrote:
|
What about Pull Requests? Release should also prepared by branch + PR? |
Not sure what to do best long term, tho preparing pull request into a branch for testing prior to merging is always a good idea! Feel free to prepare anything into individual testing branches and and/or collate those testing branches into a release branch, that’s generally how I’d do it.
|
@davidjrice For my own gems, I will merge it into But you mentioned that "preparing pull request into a branch for testing prior to merging is always a good idea!" and I don't understand what it means. |
@davidjrice @davidjrice As we're going to use in production, I'm interessed too. I'm committed to support further Rails versions and minor changes like #300 #294 etc.. |
I think the recommendation is to stop using gems like this and switch to site-based CDN, cloudfront can now pull edge assets from a server of your choosing (i.e. your rails app), and automatically gzip them. That's what i'm doing, which of course has the benefit of speeding up deployments by a fair amount, and not using S3 to store assets that exist on your server anyway. Better!! |
@mbhnyc Some applications require it, some don't |
@davidjrice |
So, AssetSync has moved. Apologies for the tumbleweeds and lack of response on issues of late. The community has been doing a good job of keeping on top of things with plenty of network activity. Thanks for that.
Anything else I should be doing? Let me know.
Best,
Dave
The text was updated successfully, but these errors were encountered: