Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported data from previous year cannot be imported #304

Open
psvenk opened this issue Jun 25, 2021 · 0 comments
Open

Exported data from previous year cannot be imported #304

psvenk opened this issue Jun 25, 2021 · 0 comments
Labels
frontend Suspected problem with frontend (client-side code in public directory)
Milestone

Comments

@psvenk
Copy link
Member

psvenk commented Jun 25, 2021

Because previous year data do not include all of the same information from current year data, attempting to import data exported from the previous year throws errors in the import code. There also seem to be some errors relating to the absence of the "current" quarter in imported data; making our code more versatile not only fixes this but paves the way for doing away with special-casing "current quarter" in #82.

I have done a little bit of investigation toward a fix; some WIP code is in the fix-import branch (b758ab4) in case anyone wants to take a look. I've been following the strategy of adapting the import code to work with already exported data, but we should additionally make sure that exported files from the previous year include all of the fields that one would expect from a current-year export. Providing flexibility in the import code is still important because we don't want an export from 2.8.1 to be useless ("just export it from a newer version" isn't a valid excuse, given that Aspen makes old data inaccessible when rolling over to the new school year, and it breaks semver).

@psvenk psvenk added the frontend Suspected problem with frontend (client-side code in public directory) label Jun 25, 2021
@psvenk psvenk added this to the 2.8.2 milestone Jun 25, 2021
@psvenk psvenk modified the milestones: 2.8.2, 2.9.0 Oct 5, 2021
@tektaxi tektaxi modified the milestones: 2.9.0, 2.9.1 Jun 23, 2022
@tektaxi tektaxi modified the milestones: 2.9.1, 2.10.0 Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Suspected problem with frontend (client-side code in public directory)
Projects
None yet
Development

No branches or pull requests

2 participants