Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organizing Backend files #32

Closed
NandanUpadhyay2611 opened this issue Oct 2, 2023 · 20 comments
Closed

Organizing Backend files #32

NandanUpadhyay2611 opened this issue Oct 2, 2023 · 20 comments

Comments

@NandanUpadhyay2611
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I went through the repo, and noticed that app.js is too much loaded.(i.e contains a lot of code) and overall backend is unorganized.

Solution:
So, I will be organizing the backend code like different folders and files for controllers, routes , and more organized app.js(so that it contains only app.listen() and some important imports only)

Additional context

Kindly Assign this task to me! please!

@Artlfmj
Copy link
Owner

Artlfmj commented Oct 2, 2023

Assigned you, if you aren't on the discord already don't hesitate to join

@Artlfmj
Copy link
Owner

Artlfmj commented Oct 2, 2023

🕒 Reminder: 24-Hour Assignment Commit Deadline 🕒

Hello @NandanUpadhyay2611 ,

Thank you for accepting the assignment for this issue. We appreciate your willingness to contribute to the Course Manager project!

This is a friendly reminder that you have a 24-hour window to make your initial commit to this issue. If you are unable to make the commit within this timeframe, your assignment will be automatically removed to allow other contributors to work on it.

Please feel free to reach out if you have any questions or need assistance with the issue. We're here to help!

Happy coding! 🚀

@Artlfmj
Copy link
Owner

Artlfmj commented Oct 2, 2023

#38 both should work together :)

@Dharansh-Neema
Copy link
Contributor

@NandanUpadhyay2611 I have created config folder for DB config and passport config so make your routes and controllers accordingly.

@NandanUpadhyay2611
Copy link
Contributor Author

@Dharansh-Neema Let him accept your PR then. Actually I have organized everything already ! But not a problem ! Let your PR get merge then I will be updating my fork, and make changes accordingly.!

@NandanUpadhyay2611
Copy link
Contributor Author

@Artlfmj kind request to you! Please let me complete working. Untill don't assign same issue to others! It becomes a little more hectic! I hope you get it :)

@Dharansh-Neema
Copy link
Contributor

Thankyou so much @NandanUpadhyay2611

@Artlfmj
Copy link
Owner

Artlfmj commented Oct 3, 2023

@Artlfmj kind request to you! Please let me complete working. Untill don't assign same issue to others! It becomes a little more hectic! I hope you get it :)

🫡👍

@NandanUpadhyay2611
Copy link
Contributor Author

NandanUpadhyay2611 commented Oct 5, 2023

hey @Artlfmj ! i am encountering a new error while running the app. especially when sending post request to "/register".
it is something related to csrf ( i am attaching screen capture) , which i am not aware of what it is .
And that's why it is taking me longer!
If you want I can create an issue for the same!
rest Everything is perfectly fine with my commits only this csrf thing!
app js - course manager-cloned original repo - Visual Studio Code 10_5_2023 8_31_35 PM
app js - course manager-clonedoriginal repo - Visual Studio Code 10_5_2023 8_31_46 PM

@Artlfmj
Copy link
Owner

Artlfmj commented Oct 5, 2023

You can work on a fix :), I believe someone broke csrf with their prs

@NandanUpadhyay2611
Copy link
Contributor Author

I don't know the solution for this! i Tried searching on the internet but can't get any easy fix ! so I am creating an issue for the same!
And should i raise pr for my commits? It is all fine except this! so if someone knows the solution you can assign the issue!

@Artlfmj
Copy link
Owner

Artlfmj commented Oct 5, 2023

Sure, i'll merge yours

@Artlfmj
Copy link
Owner

Artlfmj commented Oct 5, 2023

wait wdym by raise pr

@NandanUpadhyay2611
Copy link
Contributor Author

create/make/open ??

@Artlfmj
Copy link
Owner

Artlfmj commented Oct 5, 2023

Oh yeah sorry, go ahead

@NandanUpadhyay2611
Copy link
Contributor Author

Thanks!

@NandanUpadhyay2611
Copy link
Contributor Author

#49

@Artlfmj
Copy link
Owner

Artlfmj commented Oct 11, 2023

@NandanUpadhyay2611 is this issue finished?

@NandanUpadhyay2611
Copy link
Contributor Author

Ya !

@Artlfmj
Copy link
Owner

Artlfmj commented Oct 11, 2023

Ya !

Awesome, don't hesitate to work on new stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants