Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proper CSRF Protection #22

Open
Artlfmj opened this issue Oct 1, 2023 · 13 comments
Open

Add Proper CSRF Protection #22

Artlfmj opened this issue Oct 1, 2023 · 13 comments
Labels

Comments

@Artlfmj
Copy link
Owner

Artlfmj commented Oct 1, 2023

Implement Cross-Site Request Forgery (CSRF) protection in your Express.js application to enhance security and protect against CSRF attacks. CSRF is a type of attack where an attacker tricks a user into making an unintended request on a different website without their knowledge or consent. By implementing CSRF protection, you can ensure that requests to your application are only accepted from trusted sources.

@Artlfmj Artlfmj added bug Something isn't working help wanted Extra attention is needed hacktoberfest-accepted feature backend labels Oct 1, 2023
@1-ankush-1
Copy link
Contributor

Hey assign this me as hacktoberfest

@Artlfmj
Copy link
Owner Author

Artlfmj commented Oct 1, 2023

Done

@Artlfmj
Copy link
Owner Author

Artlfmj commented Oct 1, 2023

@1-ankush-1 dont hesitate to join the discord to post updates

@Artlfmj
Copy link
Owner Author

Artlfmj commented Oct 2, 2023

Resolved by #28

@Artlfmj Artlfmj closed this as completed Oct 2, 2023
@Artlfmj
Copy link
Owner Author

Artlfmj commented Oct 2, 2023

Please add proper forms csrf verification

@Artlfmj Artlfmj reopened this Oct 2, 2023
@1-ankush-1
Copy link
Contributor

Please add proper forms csrf verification

is there any issue

@Artlfmj
Copy link
Owner Author

Artlfmj commented Oct 2, 2023

Not apparent but https://github.com/Artlfmj/course-manager/blob/main/src/app.js#L149C1-L149C1 this means youre not checking to see if the csrf is correct

@1-ankush-1
Copy link
Contributor

Not apparent but https://github.com/Artlfmj/course-manager/blob/main/src/app.js#L149C1-L149C1 this means youre not checking to see if the csrf is correct

oh ok let me fix that .

@1-ankush-1
Copy link
Contributor

Not apparent but https://github.com/Artlfmj/course-manager/blob/main/src/app.js#L149C1-L149C1 this means youre not checking to see if the csrf is correct

Hey i tried that but something is causing the crsf token to regenerate again. i individually checked every Middleware still didn't find what is causing the issue.

@Artlfmj
Copy link
Owner Author

Artlfmj commented Oct 3, 2023

Ok take your time to check the issue

@1-ankush-1
Copy link
Contributor

Ok take your time to check the issue

hey you can assign this issue to someone else . i am not able to find what is causing the problem.

@Artlfmj
Copy link
Owner Author

Artlfmj commented Oct 4, 2023

Its ok, want to work on something else?

Ok take your time to check the issue

hey you can assign this issue to someone else . i am not able to find what is causing the problem.

@1-ankush-1
Copy link
Contributor

Its ok, want to work on something else?

Ok take your time to check the issue

hey you can assign this issue to someone else . i am not able to find what is causing the problem.

ok let me see the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants