Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(request): Re-submit timeout requests #31

Closed
Sraconni opened this issue Nov 3, 2023 · 7 comments · Fixed by #47
Closed

feat(request): Re-submit timeout requests #31

Sraconni opened this issue Nov 3, 2023 · 7 comments · Fixed by #47
Assignees
Labels
enhancement New feature or request

Comments

@Sraconni
Copy link
Member

Sraconni commented Nov 3, 2023

Description

Lobby side, Add a resubmit function, allowing players whose applications have not been processed due to timeout to resubmit without changing the content and inherit the last voting results.

Source

Reduce the cumbersome steps and time-consuming of re-submitting applications for players whose applications were rejected due to timeout.

Examples (Optional)

Compare the player's UUID and whether the player has been rejected because the application timeout and was not processed.

If so, the player is allowed to choose to submit directly using the last filled-in content when submitting the application, and inherit his last unfinished voting results.

If so but the player chooses to refill the content, the application will not inherit the last unfinished voting application and will be regarded as a new application.

This feature is not applicable for new players and players who have been rejected due to voting results.

AddItional details

No

@Sraconni Sraconni added the enhancement New feature or request label Nov 3, 2023
@CarmJos
Copy link
Contributor

CarmJos commented Nov 4, 2023

Will be updated in 1.3.0.

@CarmJos CarmJos changed the title Lobby side, Add a resubmit function, allowing players whose applications have not been processed due to timeout to resubmit without changing the content and inherit the last voting results. feat(admin): Handle timeout requests. Nov 6, 2023
@CarmJos CarmJos changed the title feat(admin): Handle timeout requests. feat(request): Re-submit timeout requests Nov 6, 2023
@CarmJos CarmJos self-assigned this Nov 6, 2023
@CarmJos
Copy link
Contributor

CarmJos commented Jan 27, 2024

Since there is no record in the database of the reason why the request was closed, after deeply consideration, I decided to allow players to view past request content and voting results, whether it was due to "vote rejection" or "timeout closure". Then let themselves to decide whether to modify based on the last request or directly open a new request.

Requests will not inherit the voting results, so remember to remind players to go to the community groups/forums to attract people to vote for him (Also I think this will stimulate the enthusiasm of the community).

@CarmJos
Copy link
Contributor

CarmJos commented Jan 27, 2024

Test with VotePass-1.3.0-SNAPSHOT.zip

@CarmJos CarmJos linked a pull request Jan 27, 2024 that will close this issue
@Sraconni
Copy link
Member Author

Since there is no record in the database of the reason why the request was closed, after deeply consideration, I decided to allow players to view past request content and voting results, whether it was due to "vote rejection" or "timeout closure". Then let themselves to decide whether to modify based on the last request or directly open a new request.

Requests will not inherit the voting results, so remember to remind players to go to the community groups/forums to attract people to vote for him (Also I think this will stimulate the enthusiasm of the community).

Test with VotePass-1.3.0-SNAPSHOT.zip

Seems like a good idea, but when the rejected player resubmits the application, there seems to be no entrance to use the previous answer, please try to fix it.

@CarmJos
Copy link
Contributor

CarmJos commented Jan 28, 2024

Since there is no record in the database of the reason why the request was closed, after deeply consideration, I decided to allow players to view past request content and voting results, whether it was due to "vote rejection" or "timeout closure". Then let themselves to decide whether to modify based on the last request or directly open a new request.
Requests will not inherit the voting results, so remember to remind players to go to the community groups/forums to attract people to vote for him (Also I think this will stimulate the enthusiasm of the community).

Test with VotePass-1.3.0-SNAPSHOT.zip

Seems like a good idea, but when the rejected player resubmits the application, there seems to be no entrance to use the previous answer, please try to fix it.

In this version, i have fixed the issues that gui cannot be used if server have any rules.

Please test it again, thanks~ VotePass-1.3.0-SNAPSHOT.zip

https://github.com/ArtformGames/VotePass/actions/runs/7679998527/artifacts/1199796871

@Sraconni
Copy link
Member Author

Sraconni commented Jan 28, 2024

Since there is no record in the database of the reason why the request was closed, after deeply consideration, I decided to allow players to view past request content and voting results, whether it was due to "vote rejection" or "timeout closure". Then let themselves to decide whether to modify based on the last request or directly open a new request.
Requests will not inherit the voting results, so remember to remind players to go to the community groups/forums to attract people to vote for him (Also I think this will stimulate the enthusiasm of the community).

Test with VotePass-1.3.0-SNAPSHOT.zip

Seems like a good idea, but when the rejected player resubmits the application, there seems to be no entrance to use the previous answer, please try to fix it.

In this version, i have fixed the issues that gui cannot be used if server have any rules.

Please test it again, thanks~ VotePass-1.3.0-SNAPSHOT.zip

https://github.com/ArtformGames/VotePass/actions/runs/7679998527/artifacts/1199796871

Looks great, but there seems to be some issues with placeholder for previous request ID shown on previous request GUI.
placeholder-issues

@CarmJos
Copy link
Contributor

CarmJos commented Jan 28, 2024

Since there is no record in the database of the reason why the request was closed, after deeply consideration, I decided to allow players to view past request content and voting results, whether it was due to "vote rejection" or "timeout closure". Then let themselves to decide whether to modify based on the last request or directly open a new request.
Requests will not inherit the voting results, so remember to remind players to go to the community groups/forums to attract people to vote for him (Also I think this will stimulate the enthusiasm of the community).

Test with VotePass-1.3.0-SNAPSHOT.zip

Seems like a good idea, but when the rejected player resubmits the application, there seems to be no entrance to use the previous answer, please try to fix it.

In this version, i have fixed the issues that gui cannot be used if server have any rules.
Please test it again, thanks~ VotePass-1.3.0-SNAPSHOT.zip
https://github.com/ArtformGames/VotePass/actions/runs/7679998527/artifacts/1199796871

Looks great, but there seems to be some issues with placeholder for previous request ID shown on previous request GUI.

Done here https://github.com/ArtformGames/VotePass/actions/runs/7683465705/artifacts/1200272462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants