Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hand-write CustomComparison and CustomEquality on Timestamp #31

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Hand-write CustomComparison and CustomEquality on Timestamp #31

wants to merge 3 commits into from

Conversation

LyndonGingerich
Copy link

@LyndonGingerich LyndonGingerich commented Jun 23, 2023 •
edited
Loading

I hand-wrote the code. Should we generate it instead? But comparison and equality might just use space unnecessarily on other message types.

I implemented GetHashCode naively. Please suggest revisions freely.

Resolves #30.

@LyndonGingerich
Copy link
Author

Thanks to Isaac Abraham at Compositional IT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WellKnownTypes.Timestamp does not implement IComparable
1 participant
@LyndonGingerich