Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite ActionsLoader to use the executor system #83

Open
ghost opened this issue Aug 1, 2021 · 0 comments
Open

Rewrite ActionsLoader to use the executor system #83

ghost opened this issue Aug 1, 2021 · 0 comments
Labels
Enhancement Feature Bloat ew, why

Comments

@ghost
Copy link

ghost commented Aug 1, 2021 •
edited by ghost
Loading

Currently, ActionsLoader is inconsistent with the rest of the loader replacements. It uses a switch statement to check an element's type instead of the much more extensible IExecutor, which is used by all of the other loaders.

What should be done:

  • Add executor interfaces to ActionsLoader.
  • Rewrite LoadActionSets and ReadAction to use said executors.
  • Optionally rename ReadAction to LoadAction for consistency with other method names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Feature Bloat ew, why
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Windows10CE