Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repairable errors in extensions' XML break the game #218

Open
Arkhist opened this issue Oct 15, 2023 · 0 comments
Open

Repairable errors in extensions' XML break the game #218

Arkhist opened this issue Oct 15, 2023 · 0 comments

Comments

@Arkhist
Copy link
Owner

Arkhist commented Oct 15, 2023

When an error in the XML of an extension occurs, in current PF, the game crashes.

  1. Such errors should never cause a crash.

When such an error does not prevent the game from launching (wrongly typed IRC message)

  1. Pathfinder should tell the (user/extension developer) a list of errors it encountered (all? a selection?), unless the extension specifies to not show errors.

  2. If none of the errors are fatal, Pathfinder should allow the user to continue through to play the extension if they so desire.

Commit ed19e4a "fixed" such an error by hiding it, this should not be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant