Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move tests next to code #467

Open
gershon opened this issue Sep 25, 2024 · 15 comments
Open

feat: Move tests next to code #467

gershon opened this issue Sep 25, 2024 · 15 comments
Assignees
Labels
ODHack8 Only dust 8

Comments

@gershon
Copy link
Contributor

gershon commented Sep 25, 2024

Simplify core test file structure by moving tests in /src next to code.

/packages/core/tests/createOffer.test.ts > /packages/core/src/actions/order/createOffer.test.ts

@gershon gershon added the ODHack8 Only dust 8 label Sep 25, 2024
@sanieni6
Copy link

Hey @gershon I'll be happy to work on this once the Odhack kicks off tomorrow 🚀

@gershon
Copy link
Contributor Author

gershon commented Sep 25, 2024

Hi @sanieni6, ok let's go 🚀

@mubarak23
Copy link

@gershon have the team stated assigning issues,

this issue is part of OD-HACK 8.0, but has been assign to someone

@sanieni6
Copy link

Thanks @gershon . It'll ready for tomorrow night [UTC-5]

@sanieni6
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi! My name is Luis Sanchez, and I’m a Frontend Developer with 3 years of experience, specializing in TypeScript, React, and Next.js.
btw i was previously assigned, lol, so I am trying again

How I plan on tackling this issue

I’ll begin by reviewing the current test file structure in the /packages/core/tests directory and identifying all test files that need to be moved. I’ll then relocate these files to their corresponding locations in the /packages/core/src directory, ensuring each test file is placed next to the code it tests. I’ll update any import paths as necessary and ensure that all tests still run successfully.
Finally, run the tests

@Mystic-Nayy
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a Web3/frontend developer
With a lot of experiences in open source contribution.

How I plan on tackling this issue

I will Simplify core test file structure by moving tests in /src next to code

@raizo07
Copy link

raizo07 commented Sep 26, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hello I'll like to be assigned to work on this.

I'm a software Dev with over four years experience and have worked on a couple of projects here. Here's a link to my profile https://app.onlydust.com/u/raizo07

@bitfalt
Copy link

bitfalt commented Sep 26, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hii! My name is Daniel, I’m a Computer Science student and web3 developer. I’ve done some contributions, finished a Starknet Bootcamp, exercises on NodeGuardians, finished Starklings and I have participated in multiple Hackathons. I’m also a member of the Dojo Coding community.

How I plan on tackling this issue

I would approach this issue in the following way:

  • Gather all tests from packages/core/tests/
  • Identify where each test should go in the code
  • Start moving the tests to their respecting path
  • Make sure all the tests still pass after moving all the files
  • I would ask the maintainers if any questions come up while I'm doing the issue

@No-bodyq
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a computer science student, fullstack and web3 dev. I have contributed to a couple of open source projects in the past via only dust

How I plan on tackling this issue

I’ll first examine the test file structure in the /packages/core/tests folder to determine which files require relocation. Next, I’ll transfer these files to their respective places within the /packages/core/src folder, ensuring they are positioned next to the relevant code. I’ll adjust the import paths where necessary and confirm that all tests still pass successfully.
Finally, I’ll run the tests.

@NueloSE
Copy link

NueloSE commented Sep 26, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have a background in software development with experience in structuring and organizing codebases effectively, with my indepth experience of handling codebase i would be able to handle this task perfectly ETA < 24hrs of assignment

How I plan on tackling this issue

To simplify the core test file structure, I will move the test file from /packages/core/tests/createOffer.test.ts to its corresponding code directory at /packages/core/src/actions/order/createOffer.test.ts. This involves:

Navigating to the /packages/core/tests/ directory.
Moving the createOffer.test.ts file to the /packages/core/src/actions/order/ directory.
Updating any import paths in the test file to reflect its new location.
Running the tests to ensure everything functions correctly after the move.

@GoSTEAN
Copy link

GoSTEAN commented Sep 26, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have a solid background in blockchain development, specializing in writing and testing smart contracts using Solidity. I’ve worked on various decentralized applications (dApps), where I've built and deployed secure and efficient smart contracts on Ethereum. Additionally, I have experience in testing these contracts using frameworks like Hardhat and Truffle, ensuring they function as expected under different scenarios. My expertise in both Solidity development and rigorous testing practices will be valuable for this task.

How I plan on tackling this issue

  1. Identify Test Files:

    • Locate all test files in /packages/core/tests/ that need to be moved.
  2. Move Test Files:

    • Move each test file next to its corresponding code in /src (e.g., move /tests/createOffer.test.ts to /src/actions/order/).
  3. Update Configuration:

    • Adjust any testing configuration (like jest.config.js or vitest.config.js) to reflect the new file paths, if necessary.
  4. Run Tests:

    • Run the test suite to ensure everything works as expected after the changes.
  5. Document & Submit:

    • Update relevant documentation and submit the changes with a clear commit message.

This streamlined process focuses on maintaining test functionality while reorganizing the files.

@abdegenius
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a skilled fullstack developer with a wealth of experience in both frontend and backend JavaScript as well as my knowledge of Rustlang, With a solid foundation in testing,I have mastered frameworks like Mocha, Chai, and Jest to ensure robust, reliable code in every project. In addition to traditional web development, I have a strong background in blockchain technology, with hands-on experience in Solidity for Ethereum-based smart contracts. Moreover, I have delved into the emerging world of StarkNet, working with Cairo, a cutting-edge language tailored for STARKs, making them a versatile developer capable of bridging both traditional and decentralized web applications.

How I plan on tackling this issue

Using the available test library of the project, i can write comprehensive test cases that covers all parameters...

Copy link

onlydustapp bot commented Sep 26, 2024

The maintainer gershon has assigned sanieni6 to this issue via OnlyDust Platform.
Good luck!

@sanieni6
Copy link

Hi, @gershon I've been having problems deploying the contracts locally, specifically the orderBooks contracts, i got this error (the aborted one in the mid console):
Screenshot 2024-09-30 093101

i think it is related to this "file not found" but i double checked the route and the file does exist there:
image
i would appreciate any hint, also let me know if you want a complete walkthrough

@gershon
Copy link
Contributor Author

gershon commented Oct 1, 2024

Hi @sanieni6 , can you test local deploy using branch feat/contract-v2, lmk if you still have issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ODHack8 Only dust 8
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants