Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support batch/listing offers #415

Open
kwiss opened this issue Jul 19, 2024 · 37 comments
Open

Support batch/listing offers #415

kwiss opened this issue Jul 19, 2024 · 37 comments
Labels
app:sdk Ark Project SDK good first issue Good for newcomers javascript Pull requests that update Javascript code

Comments

@kwiss
Copy link
Contributor

kwiss commented Jul 19, 2024

How does that work ?
to support the batch we need to create a new SDK function to support multicall for listing/offer creation

@kwiss kwiss changed the title Support batch offers Support batch/listing offers Jul 19, 2024
@ShantelPeters
Copy link
Contributor

@kwiss can I work on this ?

@ooochoche
Copy link

@kwiss I would love to work on this, can you provide more info about the issue?

@kwiss
Copy link
Contributor Author

kwiss commented Aug 22, 2024

hey @ShantelPeters any of you can take that if not i'll assign @ooochoche tomorrow

@kwiss kwiss added good first issue Good for newcomers app:sdk Ark Project SDK javascript Pull requests that update Javascript code labels Aug 22, 2024
@ShantelPeters
Copy link
Contributor

I am already working on the issue sir @kwiss

@ShantelPeters ShantelPeters removed their assignment Aug 31, 2024
@DiegoB1911
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I'm a Full Stack Developer with two years of experience, primarily in Next.js. I'm also an active member of Dojo Coding, where I'm expanding my skills in Cairo and Web3 technologies. I'm eager to learn, contribute, and be part of this project.

How I plan on tackling this issue

To solve this issue, I would:

  1. Understand the Requirements
  2. Design the SDK Function
  3. Implement and Test the SDK
  4. Document the Code

@Suhas-30
Copy link

Suhas-30 commented Sep 7, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi
I'm web 3 developer and I have grip in working backend developer. I have strong Fundamentals. I'm ready to opensource contribution

How I plan on tackling this issue

First I analyze the problem statement then I start to think what tools required to solve. To solve I break problem into smaller then try to solve it will be faster way i think

@martinvibes
Copy link

hello @kwiss let me work on this

@Iwueseiter
Copy link

@kwiss can I work on this?
This will be my first time contributing to this project and I’d get it done quickly as it has been opened for some time now.

@Mystic-Nayy
Copy link

Mystic-Nayy commented Sep 24, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a web3/fronted developer

How I plan on tackling this issue

@kwiss Can I work on this?

@kwiss kwiss assigned Mystic-Nayy and unassigned Mystic-Nayy Sep 24, 2024
@kwiss
Copy link
Contributor Author

kwiss commented Sep 26, 2024

@Gift-Naomi if you want to take this issue, please apply from the onlydust app

@diegoTech14
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hello @kwiss,

I'm a software engineer from Costa Rica and a member of Dojo Coding. I have worked with technologies such as JavaScript, Node.js, PhP, Java, C#, Cairo. I'd love the opportunity to help with this issue and contribute to your project.

How I plan on tackling this issue

Here's an improved version of your message with clearer structure and more professional tone:

Steps I will take to address the issue:

  • Analyze the Requirements: I will thoroughly review the requirements to gain a deep understanding of the issue and explore the most efficient solution.

  • Design and Implement the SDK Function: I will proceed with designing and coding the SDK function to effectively resolve the problem, ensuring it aligns with the project needs.

  • Create Test Cases: I will design a comprehensive set of test cases to validate the SDK function and ensure its correctness and performance.

Additionally, I can document the function if needed, providing clear usage instructions and technical details.

Looking forward to your feedback!

Best regards,

Diego Duarte Fernández.

@vic-Gray
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a back-end developer with a solid foundation in NestJS, TypeScript, javascript, databases (MongoDB and PostgreSQL), and Supabase for handling scalable data-driven applications. I also have experience with HTML, CSS, React.js, which allows me to work on both the back-end and front-end of applications, providing end-to-end solutions.

In my recent projects, I've gained experience with Supabase, where I optimized database queries, ensuring efficient data retrieval and storage. My experience with NestJS has enabled me to design modular and scalable APIs that handle complex data flows and integrate seamlessly with databases.

I have dealt with issues such as type management and handling large-scale data operations efficiently. This experience can be leveraged to implement robust batch processing mechanisms and handle multicall functionality, especially when optimizing for speed and performance across systems.

Moreover, my knowledge of PostgreSQL has given me the ability to design and optimize databases for performance, ensuring the back-end systems scale well with the front-end user interactions, particularly in high-demand environments.

How I plan on tackling this issue

Understanding Requirements: I'd start by understanding the exact needs of the batch functionality, such as the max number of listings/offers that can be processed at once and ensuring compatibility with existing systems.

Design Multicall Logic: I’d focus on designing an SDK function to support multicall. This includes encoding the function calls for each individual listing/offer creation and wrapping them into a single transaction for submission.

Efficiency Considerations: I’d take care of gas optimization (if applicable) and reduce redundant calls. Handling failures in a batch is key — either continuing with the remaining operations or rolling back the entire batch.

Testing: Rigorous testing would be necessary to ensure that the multicall function handles different edge cases like partial failures, transaction limits.

@Deepak2623
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

.

How I plan on tackling this issue

.

@CollinsC1O
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hello @kwiss I'm a front-end and a blockchain developer and I will love to work on this. please assign

How I plan on tackling this issue

How I intend to approach this issue:

  • I will create a new SDK function to support multicall for batch listing/offer creation.
  • I will implement logic to allow multiple offers to be processed in a single call.
  • I will ensure the multicall function works for valid batches and handles errors for invalid offers.
    Thanks

@Omneesh9837
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

i am full stack developer

@NueloSE
Copy link

NueloSE commented Oct 20, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Am an Expirenced frontend developer with solid understanding of sdk tool kit

How I plan on tackling this issue

I have made previous contribution to this sdk. Using my previous experience I will be able to handle this task

@DanielEmmanuel1
Copy link

@ptisserand This is still open
I applied a few days ago, can i get assigned this task?

1 similar comment
@DanielEmmanuel1
Copy link

@ptisserand This is still open
I applied a few days ago, can i get assigned this task?

@DanielEmmanuel1
Copy link

@kwiss Is this issue still open for contribution?
I'll like to take it up

@genamol
Copy link

genamol commented Oct 30, 2024

I’d like to resolve this.

@DanielEmmanuel1
Copy link

Hello, Please I'll like to tackle this

@sotoJ24
Copy link

sotoJ24 commented Oct 31, 2024

Hi, Team. To assist batch listing/bid generation, I propose that we develop a multicall functionality in the SDK that allows users to submit numerous listings or bids in a single transaction. This technique will streamline operations, minimize gas costs, and enhance speed by limiting single transactions on the network, making it simpler for high frequency users to easily connect with the Starknet ecosystem. This is my concept, and I hope you can assist.
Sincerely
Josué From Dojo Coding,

@Shaarps
Copy link

Shaarps commented Nov 1, 2024

Let me handle this issue!

@azzadpandit1122
Copy link

Could I take a shot at this?

@DanielEmmanuel1
Copy link

May I take care of this?

@kwiss Can i please take up this issue.
I'm a returning contributor to this repo and can have this delivered in less that 48 hours

@Akpjunior94
Copy link

Can I be assigned to this?

@lordpharz
Copy link

Can I work on this, please?

@Tobybrandsync
Copy link

I’d like to resolve this. To enable batch processing, we’ll create a new SDK function supporting multicall. This function will bundle multiple actions—such as listing or offer creation—into a single transaction, reducing gas fees and improving efficiency. It works by executing all calls in one blockchain interaction, allowing users to list multiple items or make multiple offers simultaneously without separate transactions for each.

@Solokingx
Copy link

I'd like to handle this task.

@SavageWhale
Copy link

I’m interested in this one.

@daksha-aeer
Copy link

Can I work on this, please?

@xJeffx23
Copy link

Yes, I can take on this task. Although I haven’t made contributions to open source before, I can take this opportunity and make it happen

@teskpicoin
Copy link

May I handle this issue?

@Jagadeeshftw
Copy link

Let me handle this issue!

@RomThpt
Copy link

RomThpt commented Dec 6, 2024

Can I try solving this issue?

@ryzen-xp
Copy link

I’m interested in this one.

@Nanle100
Copy link

Could I try solving this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:sdk Ark Project SDK good first issue Good for newcomers javascript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests