Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a .pylintrc file #974

Closed
wants to merge 1 commit into from

Conversation

amilcarlucas
Copy link
Contributor

No description provided.

@peterbarker
Copy link
Contributor

How do the rules interact with the flake8 tests which we already do?

@amilcarlucas
Copy link
Contributor Author

They do not, pylint is much more compreensive than flake8 and it runs a lot slower. This file is just to run pylint localy for now.
Once more of the code gets linted, we can automate this and activate fail on errors.

@amilcarlucas
Copy link
Contributor Author

BTW better than flake8 is ruff

@amilcarlucas
Copy link
Contributor Author

name: Ruff

on: [push, workflow_dispatch]

#concurrency:
#  group: ci-${{github.workflow}}-${{ github.ref }}
#  cancel-in-progress: true

jobs:
  build:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        python-version: ['3.12']

    steps:
      - name: Checkout
        uses: actions/checkout@v4
        with:
          fetch-depth: 0

      - name: Install dependencies
        run: |
          python -m pip install -U ruff

      - name: Lint with Ruff
        run: |
          ruff check --output-format=github .

@tridge
Copy link
Contributor

tridge commented Sep 4, 2024

ruff sounds like better option, pylint is too slow

@tridge tridge closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants