Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos and inconsistent logical AND test in ImageConvert.py #6

Open
gernot-hochmuth opened this issue Nov 3, 2023 · 0 comments
Open

Comments

@gernot-hochmuth
Copy link

In file ImageConvert.py there are typos in lines 32 and 33:

iamge = arr.reshape(Height,Width,4)
return cv2.flip(iamge,0)

instead of iamge it should read image.

In line

if color_mode < 0 and color_mode > 3:
the logical and test if color_mode < 0 and color_mode > 3: cannot be fulfilled.
It possibly should read if color_mode < 0 or color_mode > 3:. The logical or test will cover all cases that have not been dealt with before in function convert_color.

gernot-hochmuth added a commit to gernot-hochmuth/ArduCAM_USB_Camera_Shield_Python_Demo that referenced this issue Nov 3, 2023
gernot-hochmuth added a commit to gernot-hochmuth/ArduCAM_USB_Camera_Shield_Python_Demo that referenced this issue Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant