Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prematurely abort ProcSendEvent if a ClientMsg has been fordwarded #1078

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

uli42
Copy link
Member

@uli42 uli42 commented Jun 29, 2024

Fixes #1065

@sunweaver
Copy link
Member

Events.c:4211:6: error: conflicting types for 'nxagentForwardRemoteExpose'; have 'void(void)'
7436
 4211 | void nxagentForwardRemoteExpose(void)
7437
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
7438
Events.c:227:13: note: previous declaration of 'nxagentForwardRemoteExpose' with type 'int(void)'
7439
  227 | static Bool nxagentForwardRemoteExpose(void);
7440
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~
7441
Events.c:227:13: warning: 'nxagentForwardRemoteExpose' used but never defined
7442
make[7]: *** [Makefile:575: Events.o] Error 1

@uli42 CI failure. Can you take a look? Thanks.

@uli42 uli42 force-pushed the pr/fix_qt_clientevents branch from dd3c016 to 92eaa85 Compare July 10, 2024 21:00
@uli42
Copy link
Member Author

uli42 commented Jul 10, 2024 via email

@sunweaver
Copy link
Member

Rebased and re-running CI...

@uli42
Copy link
Member Author

uli42 commented Nov 20, 2024 via email

Copy link
Member

@sunweaver sunweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, seems to work...

@sunweaver sunweaver merged commit 58d42b6 into ArcticaProject:3.6.x Nov 23, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rootless mode: Qt applications do not exit
2 participants