-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prematurely abort ProcSendEvent if a ClientMsg has been fordwarded #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunweaver
force-pushed
the
pr/fix_qt_clientevents
branch
from
June 30, 2024 13:47
7bd97d9
to
dd3c016
Compare
@uli42 CI failure. Can you take a look? Thanks. |
uli42
force-pushed
the
pr/fix_qt_clientevents
branch
from
July 10, 2024 21:00
dd3c016
to
92eaa85
Compare
pushed a fixed version
…On Wed, Jul 10, 2024 at 9:10 PM Mike Gabriel ***@***.***> wrote:
Events.c:4211:6: error: conflicting types for 'nxagentForwardRemoteExpose'; have 'void(void)'
7436
4211 | void nxagentForwardRemoteExpose(void)
7437
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
7438
Events.c:227:13: note: previous declaration of 'nxagentForwardRemoteExpose' with type 'int(void)'
7439
227 | static Bool nxagentForwardRemoteExpose(void);
7440
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
7441
Events.c:227:13: warning: 'nxagentForwardRemoteExpose' used but never defined
7442
make[7]: *** [Makefile:575: Events.o] Error 1
@uli42 <https://github.com/uli42> CI failure. Can you take a look? Thanks.
—
Reply to this email directly, view it on GitHub
<#1078 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQHBZEJDKKDZMK37UV6RSLZLWBKBAVCNFSM6AAAAABKDLDW6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRRGI2DCMZSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
sunweaver
force-pushed
the
pr/fix_qt_clientevents
branch
from
November 20, 2024 20:52
92eaa85
to
d4ea492
Compare
Rebased and re-running CI... |
#1015 (comment)
metions that there's Nullpointer check missing in
ForwardClientMessage. Maybe you can add one while at it...
…On Wed, Nov 20, 2024 at 9:53 PM Mike Gabriel ***@***.***> wrote:
Rebased and re-running CI...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
sunweaver
force-pushed
the
pr/fix_qt_clientevents
branch
from
November 22, 2024 21:02
d4ea492
to
eb6cb7d
Compare
sunweaver
force-pushed
the
pr/fix_qt_clientevents
branch
from
November 23, 2024 07:45
f9cbd37
to
6e08d43
Compare
sunweaver
approved these changes
Nov 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, seems to work...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1065