Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only dots shown with HTTPS Everywhere enabled #5

Open
machawk1 opened this issue Oct 19, 2017 · 2 comments
Open

Only dots shown with HTTPS Everywhere enabled #5

machawk1 opened this issue Oct 19, 2017 · 2 comments

Comments

@machawk1
Copy link

Per discussion with @davidar on ArchiveLabs #general Slack channel, attempting to use this service with the HTTPS Everywhere Chrome add-on results in dots being shown indefinitely without any thumbnail images. I was able to replicate the experience with Chrome 61 and HTTPS Everywhere 2017.10.4 (both latest). Access the deployment on https results in an insecure message but the same display.

screen shot 2017-10-19 at 12 22 55 pm

@jonobr1
Copy link
Collaborator

jonobr1 commented Oct 19, 2017

This is a CORS error. The images that we're serving need to be A) available over http and https protocols and B) add a header for access-control-allow-origin with the value of the site or of all sites with * as can be seen here: https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS

@rchrd2
Copy link
Contributor

rchrd2 commented Nov 8, 2017

The images are currently served directly from a nodejs microservice. I'd need to do some work to get it served through https.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants