Communicating API errors #1272
marcustyphoon
started this conversation in
Tech Office
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
#1271 is most likely an
apifetch
failure. We have a couple of problems:apiFetch
failing does not always callnotify
with e.g. the friendly contents ofbody.errors[0].detail
("Looks like something went wrong. Please try again."). This has been implemented with try-catch in some places, but not universally.body
property from the code that uses the result).Some thoughts I had about this were that the notify call, a console.error, or both could be in apiFetch itself (which could then re-throw). Maybe the notify call is better off as situational, though, as if the Tumblr API changes/breaks, that could result in a whole bunch of notifications with no context.
Beta Was this translation helpful? Give feedback.
All reactions