InscriberBlockEntity has logical bug, making inscribe slower and taking more energy than expected.

[Yang00002]

Describe the bug

The annotation in the code said that inscribe require 16 + ceil(MAX_PROCESSING_STEPS / speedFactor) ticks. Since MAX_PROCESSING_STEPS is 200, it's expected to take 16 + ceil(200 / speedFactor) ticks.

But the bottom lines of the code use this.getProcessingTime() > this.getMaxProcessingTime() instead of >=. The speedFactor of 4 speed cards is 50, so the processingTime after 4 ticks is 200, 200 is not bigger than maxProcessingTime(200), so inscribe will need 16 + 5 = 21 ticks instead of 20 ticks.

How to reproduce the bug

Using an inscriber with 4 speed cards, inscribe once will take 21 ticks, 2.5kAE. Overall, an inscriber can only inscribe 3429 times an hour, a full energy cell only supports it to inscribe 80 times.

Expected behavior

Using an inscriber with 4 speed cards, inscribe once take 20 ticks, 2kAE. An inscriber can inscribe 3600 times an hour, a full energy cell supports it to inscribe 100 times.

Additional details

Up to now, I have found this bug in code in fabric/1.20, forge/1.20 and main branch.

Which minecraft version are you using?

1.20

On which mod loaders does it happen?

Fabric

Crash log

no crash