feat: include proxy ABIs in contract-type ABIs #2413
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #1249
I could no longer call
masterCopy()
in a safe proxy since #2400I not 100% sure why but this PR fixes it.
I think before, it was never actually recognized as a safe proxy...
Anyway, the
masterCopy()
ABI is sort of hidden.And proxy ABIs in general (that were not hidden) were not included in the contract-types ABIs you could call.
This PR makes both of those things work.
How I did it
masterCopy()
be included..masterCopy()
.masterCopy()
Can get ape-safe tests to pass again, altho this all started because was debuggin a different problem...
Show it Working
Example of Safe!
First, delete any cached contract. This also deletes the proxy info that is cached, you can check!
Next, get this contract as if it is the first time! Notice it uses Etherscan...
Show you can call both proxy ABIs as well as the actual safe ABIs:
Checklist