Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect image release tags in build #2228

Merged
merged 12 commits into from
Aug 23, 2024

Conversation

johnson2427
Copy link
Contributor

@johnson2427 johnson2427 commented Aug 21, 2024

What I did

The tag that is created when merged to main is main. We want this to be latest and then on version release, we want this to be stable

fixes: APE-1769

How I did it

Added the tag to the build yaml

How to verify it

After merge, check the release

Checklist

  • All changes are completed
    - [ ] New test cases have been added
    - [ ] Documentation has been updated

@antazoey
Copy link
Member

I am guessing this is container-related?

@johnson2427
Copy link
Contributor Author

I am guessing this is container-related?

yes it is, not getting the right tags on merge to main

@johnson2427 johnson2427 changed the title fix: incorrect tags in build fix: incorrect image release tags in build Aug 21, 2024
@johnson2427
Copy link
Contributor Author

These changes should do what we're looking for. I'm not familiar with tagging in github, so I'm riding on documentation, but still a little unclear on this

@johnson2427 johnson2427 force-pushed the fix/tag-in-build branch 2 times, most recently from 9097d28 to a597ba9 Compare August 21, 2024 15:43
@johnson2427 johnson2427 self-assigned this Aug 21, 2024
fubuloubu
fubuloubu previously approved these changes Aug 21, 2024
.github/workflows/build.yaml Outdated Show resolved Hide resolved
@fubuloubu
Copy link
Member

fubuloubu commented Aug 21, 2024

Noticed that the untagged versions were getting pushed from this PR, did a597ba9 resolve that?


ref: https://github.com/ApeWorX/ape/pkgs/container/ape/261370690

@fubuloubu
Copy link
Member

@johnson2427
Copy link
Contributor Author

Noticed that the untagged versions were getting pushed from this PR, did a597ba9 resolve that?

ref: https://github.com/ApeWorX/ape/pkgs/container/ape/261370690

I'm reviewing docs right now, this isn't supposed to push unless it's merged to main

@fubuloubu
Copy link
Member

Lastly, would love it if the untagged versions didn't get published at all, feel like that bloats things

fubuloubu
fubuloubu previously approved these changes Aug 22, 2024
.github/workflows/build.yaml Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
@johnson2427
Copy link
Contributor Author

Lastly, would love it if the untagged versions didn't get published at all, feel like that bloats things

you don't want to release unless it's a tagged version? So don't release on merge to main?

@johnson2427 johnson2427 force-pushed the fix/tag-in-build branch 2 times, most recently from ed5d936 to 13bf130 Compare August 23, 2024 13:39
@fubuloubu
Copy link
Member

Lastly, would love it if the untagged versions didn't get published at all, feel like that bloats things

you don't want to release unless it's a tagged version? So don't release on merge to main?

No no, those random untagged releases which are image hashes. Don't know where those come from

@johnson2427
Copy link
Contributor Author

Lastly, would love it if the untagged versions didn't get published at all, feel like that bloats things

you don't want to release unless it's a tagged version? So don't release on merge to main?

No no, those random untagged releases which are image hashes. Don't know where those come from

I think this is resolved. I don't see it in the package releases. And I'm no longer pushing until we merge to main. We should be okay here

@fubuloubu
Copy link
Member

Lastly, would love it if the untagged versions didn't get published at all, feel like that bloats things

you don't want to release unless it's a tagged version? So don't release on merge to main?

No no, those random untagged releases which are image hashes. Don't know where those come from

I think this is resolved. I don't see it in the package releases. And I'm no longer pushing until we merge to main. We should be okay here

So we can get this merged to see?

fubuloubu
fubuloubu previously approved these changes Aug 23, 2024
@johnson2427
Copy link
Contributor Author

Lastly, would love it if the untagged versions didn't get published at all, feel like that bloats things

you don't want to release unless it's a tagged version? So don't release on merge to main?

No no, those random untagged releases which are image hashes. Don't know where those come from

I think this is resolved. I don't see it in the package releases. And I'm no longer pushing until we merge to main. We should be okay here

So we can get this merged to see?

we can merge now to see. We won't know for sure on the tagged release until we do a tagged version release

@johnson2427
Copy link
Contributor Author

If this does not work, I'm removing the metadata step and forcefully injecting the tags

@johnson2427 johnson2427 enabled auto-merge (squash) August 23, 2024 22:12
@johnson2427 johnson2427 merged commit 50e9d26 into ApeWorX:main Aug 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants