-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect image release tags in build #2228
Conversation
I am guessing this is container-related? |
yes it is, not getting the right tags on merge to main |
These changes should do what we're looking for. I'm not familiar with tagging in github, so I'm riding on documentation, but still a little unclear on this |
9097d28
to
a597ba9
Compare
Noticed that the untagged versions were getting pushed from this PR, did a597ba9 resolve that? ref: https://github.com/ApeWorX/ape/pkgs/container/ape/261370690 |
Also can you delete this? |
I'm reviewing docs right now, this isn't supposed to push unless it's merged to main |
Lastly, would love it if the untagged versions didn't get published at all, feel like that bloats things |
you don't want to release unless it's a tagged version? So don't release on merge to main? |
ed5d936
to
13bf130
Compare
No no, those random untagged releases which are image hashes. Don't know where those come from |
I think this is resolved. I don't see it in the package releases. And I'm no longer pushing until we merge to main. We should be okay here |
So we can get this merged to see? |
13bf130
to
9bdd08d
Compare
we can merge now to see. We won't know for sure on the tagged release until we do a tagged version release |
If this does not work, I'm removing the metadata step and forcefully injecting the tags |
4ce6cc8
to
425bd43
Compare
What I did
The tag that is created when merged to
main
ismain
. We want this to belatest
and then on version release, we want this to bestable
fixes: APE-1769
How I did it
Added the tag to the build yaml
How to verify it
After merge, check the release
Checklist
- [ ] New test cases have been added- [ ] Documentation has been updated