ProviderContextManager is not concurrency-aware

[fubuloubu]

Ran into this with a Silverback bot using the new FORK_MODE PR in the Silverback SDK (currently solving with an async concurrency lock)

Not sure this can be resolved without full async support of Ape's network management stack

[linear]

APE-1848 `ProviderContextManager` is not concurrency-aware

[fubuloubu]

Not quite sure what the issue was, but it lead to weird "trying to fork network mainnet-fork is not possible" or "ecosystem 'base' has no network mainnet-fork-fork" bugs

[antazoey]

Not quite sure what the issue was, but it lead to weird "trying to fork network mainnet-fork is not possible" or "ecosystem 'base' has no network mainnet-fork-fork" bugs

i can at least improve the error

[antazoey]

Maybe this helps a little? #2349

[fubuloubu]

Maybe this helps a little? #2349

Yes I believe that will prevent the error, but not totally ideal

I will learn if it works well enough or not when I try to implement backtesting to silverback (at some later date)

for reference, the backtesting mode of silverback takes a range of blocks and executes each block (and relevant event logs/transactions) in an isolated fork that only exists for the span of that one block

[antazoey]

Wha about a fork-lock for each network so you can't fork until you hold the lock, waiting for other threads / processes to release the lock

[fubuloubu]

Wha about a fork-lock for each network so you can't fork until you hold the lock, waiting for other threads / processes to release the lock

I don't think we need that now with the synchronous version, I will test this fix to see if it works good enough for my use case and get back to you

[fubuloubu]

This might have been a bit of a false positive, it seems like the provider context manager was not resetting the context stack item when a failure was occuring within the context:

INFO:     Starting 'anvil' process.                                                                                                                                
INFO:     Stopping 'anvil' process.                                                                                                                                
SUCCESS:  exec_event1[...] - 1.150s (8.8%)                 
INFO:     exec_event2[...] - Started                        
INFO:     Starting 'anvil' process.                                                                                                                                
INFO:     exec_block[...] - Started                                
ERROR:    exec_block[...] - 0.000s (0.0%)                          
INFO:     check_logs[...] - Started                                
ERROR:    check_logs[...] - 0.000s (0.0%)                          
INFO:     exec_event1[...] - Started                       
ERROR:    exec_event1[...] - 0.000s (0.0%)                 
INFO:     exec_block[...] - Started                                
ERROR:    exec_block[...] - 0.000s (0.0%)                          
INFO:     check_logs[...] - Started                                
ERROR:    check_logs[...] - 0.000s (0.0%)                          
WARNING:  Runtime error(s) detected, shutting down:                                                                                                                
Unable to fork network 'mainnet-fork'.                                                                                                                             
INFO:     bot_shutdown - Started                                                                                                                                   
ERROR:    bot_shutdown - 0.000s (0.0%)                                                                                                                             
ERROR:    Errors while shutting down:                                                                                                                              
Unable to fork network 'mainnet-fork'.                                                                                                                             
INFO:     Stopping 'anvil' process.                                                                                                                                
ERROR:    exec_event2[...] - 2.500s (19.2%)

[antazoey]

false positive

I am having trouble seeing any positive here. What is the false-positive part?

[fubuloubu]

"ecosystem 'base' has no network mainnet-fork-fork"

basically, "ecosystem 'base' has no network 'mainnet-fork-fork'" may be a symptom of it not exiting the forked network context when an exception occurs within the forked network context (e.g. executing the silverback event handler function)