Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider committing compiled pb2 files to repo #171

Open
randomshinichi opened this issue Apr 19, 2019 · 0 comments
Open

Consider committing compiled pb2 files to repo #171

randomshinichi opened this issue Apr 19, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@randomshinichi
Copy link
Collaborator

randomshinichi commented Apr 19, 2019

There is no need to complicate the build process by having nanopb compile it all the time. Just commit the generated code. The burden of setting up the protobuf compiler is left to the developer - once, on his machine, not on the build systems as well and managing the scripts for them.

@lorepieri8 lorepieri8 added the enhancement New feature or request label Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants