Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve Zephyr logging #101

Open
2 tasks
pcppcp opened this issue Oct 23, 2018 · 5 comments
Open
2 tasks

improve Zephyr logging #101

pcppcp opened this issue Oct 23, 2018 · 5 comments
Assignees
@victor999
Labels
good first issue Good for newcomers

Comments

@pcppcp
Copy link
Contributor

pcppcp commented Oct 23, 2018

logging in our modules is a mess (printk() & co. everywhere)

  • investigate how logging works in zephyr
  • use proper log module setup and replace all stinky printk()s with log calls
@pcppcp pcppcp added the good first issue Good for newcomers label Oct 23, 2018
@victor999
Copy link

It seems like only UART log is available. If it is acceptable - I would like to work on it

@pcppcp
Copy link
Contributor Author

pcppcp commented Oct 25, 2018

hey Victor,
sure, take a look. Ask if you have any questions.

relevant doc:
https://docs.zephyrproject.org/1.12.0/subsystems/logging/system_log.html

@pcppcp pcppcp assigned pcppcp and victor999 and unassigned pcppcp Oct 25, 2018
@victor999
Copy link

I enabled logging in config and implemented logging in sensor_service for now. I can pull it as first phase. Or you prefer to replace everything and then pull it. I tested the mechanism in hardware board. I
can see log messages on UART.

@pcppcp
Copy link
Contributor Author

pcppcp commented Oct 27, 2018

Please create a PR, it's easier to discuss the code that way.

@victor999
Copy link

#120

@pcppcp pcppcp mentioned this issue Oct 31, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@victor999 victor999

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pcppcp @victor999