Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2P: listen endpoint option to specify no blocks #1101

Open
heifner opened this issue Jan 15, 2025 · 0 comments · May be fixed by #1115
Open

P2P: listen endpoint option to specify no blocks #1101

heifner opened this issue Jan 15, 2025 · 0 comments · May be fixed by #1115
Assignees
@heifner
Labels
enhancement New feature or request 👍 lgtm OCI Work exclusive to OCI team
Milestone
Spring v1.1.0-rc1

Comments

@heifner
Copy link
Member

heifner commented Jan 15, 2025

https://hackmd.io/-766AO7CTjCb99TOAt_jSQ

Add option to p2p-listen-endpoint (:trx) which tells all connections on that endpoint to not relay blocks.
This would be useful for public relay nodes so blocks are not sent to it.

Currently, blocks are sent to public relay nodes (all peers) after a block header has been validated and the block has not yet been received from the node.

A test I ran locally with 17 public P2P peers, echoed back to 5 on average for every block. It is highly doubtful those peers needed those blocks.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jan 15, 2025
@heifner heifner added the enhancement New feature or request label Jan 15, 2025
@bhazzard bhazzard added 👍 lgtm and removed triage labels Jan 15, 2025
@heifner heifner self-assigned this Jan 20, 2025
@heifner heifner added the OCI Work exclusive to OCI team label Jan 20, 2025
@heifner heifner moved this from Todo to In Progress in Team Backlog Jan 20, 2025
@heifner heifner added this to the Spring v1.1.0-rc1 milestone Jan 20, 2025
heifner added a commit that referenced this issue Jan 22, 2025
@heifner
GH-1101 Move split_host_post_type to net_utils and improve logging
bf54556
heifner added a commit that referenced this issue Jan 22, 2025
@heifner
GH-1101 Add more descriptive error message
d78ebb5
heifner added a commit that referenced this issue Jan 22, 2025
@heifner
GH-1101 Add integration test for p2p-listen-address specification of …
07793ad 
…:trx
heifner added a commit that referenced this issue Jan 22, 2025
@heifner
GH-1101 Add support for p2p-listen-endpoint specification of only wan…
8321858 
…ting trx or only wanting blocks
heifner added a commit that referenced this issue Jan 22, 2025
@heifner
GH-1101 Cleanup p2p help
65bc7d7
heifner added a commit that referenced this issue Jan 22, 2025
@heifner
GH-1101 For outgoing connections do not include the listen address co…
3b80641 
…nnection type to avoid the node adopting the mode
heifner added a commit that referenced this issue Jan 22, 2025
@heifner
GH-1101 Do not include connection type in outgoing p2p_address; other…
3b82bed 
…wise type can be set so that trxs are not sent to peer
heifner added a commit that referenced this issue Jan 22, 2025
@heifner
GH-1101 Update test to allow for block processing after bios kill
bb55a41
heifner added a commit that referenced this issue Jan 22, 2025
@heifner
GH-1101 Ignore block requests on trx only connections
a654723
@heifner heifner linked a pull request Jan 23, 2025 that will close this issue
Open
@BenjaminGormanPMP BenjaminGormanPMP moved this from In Progress to Awaiting Review in Team Backlog Jan 23, 2025
heifner added a commit that referenced this issue Jan 24, 2025
@heifner
GH-1101 Improve address parsing logic and add additional tests.
6c2442b
heifner added a commit that referenced this issue Jan 24, 2025
@heifner
GH-1101 Additional test cases and cleanup
641eba1
@heifner heifner linked a pull request Jan 24, 2025 that will close this issue
P2P: Add p2p-listen-endpoint :trx & :blk support #1115
Open
heifner added a commit that referenced this issue Jan 25, 2025
@heifner
Merge remote-tracking branch 'spring/GH-1091-block-nack' into GH-1101-…
a2d6f9e 
…p2p-no-blocks
heifner added a commit that referenced this issue Jan 25, 2025
@heifner
GH-1101 Add previous to block_notice_message which allows for immedia…
ad712db 
…te determination if a block request is needed. Also include in the block request_message the peer head. The peer head allows the node to determine if on a fork and send from LIB instead. Also create block_on_fork function to remove duplicate code.
heifner added a commit that referenced this issue Jan 25, 2025
@heifner
GH-1101 Add previous to block_notice_message which allows for immedia…
2c1cd11 
…te determination if a block request is needed. Also include in the block request_message the peer head. The peer head allows the node to determine if on a fork and send from LIB instead. Also create block_on_fork function to remove duplicate code.
heifner added a commit that referenced this issue Jan 25, 2025
@heifner
Merge branch 'GH-1091-block-nack' into GH-1101-p2p-no-blocks
6a0a92b
heifner added a commit that referenced this issue Jan 25, 2025
@heifner
Merge branch 'GH-1091-block-nack' into GH-1101-p2p-no-blocks
ee00bd8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
enhancement New feature or request 👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Status: Awaiting Review
Milestone
Spring v1.1.0-rc1
Development

Successfully merging a pull request may close this issue.

P2P: Add p2p-listen-endpoint :trx & :blk support AntelopeIO/spring
3 participants
@bhazzard @heifner @enf-ci-bot