Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleos set code/cleos set abi don't appear to work #1868

Closed
spoonincode opened this issue Nov 7, 2023 · 2 comments · Fixed by #1915
Closed

cleos set code/cleos set abi don't appear to work #1868

spoonincode opened this issue Nov 7, 2023 · 2 comments · Fixed by #1915
Assignees
Labels
bug Something isn't working 👍 lgtm

Comments

@spoonincode
Copy link
Member

cleos set code and cleos set abi don't seem to work on main, and I'm suspicious they haven't worked in a long time.

The problem is contractPath is empty here when doing set code or set abi and, at least on main, this causes std::filesystem::canonical() to throw

std::filesystem::path cpath = std::filesystem::canonical(std::filesystem::path(contractPath));

This looks to be a straightforward fix; adding a test will take longer than the fix itself.

@spoonincode spoonincode added the bug Something isn't working label Nov 7, 2023
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Nov 7, 2023
@bhazzard bhazzard added this to the Leap v5.0.1 milestone Nov 9, 2023
@bhazzard
Copy link

bhazzard commented Nov 9, 2023

We need to verify that this was broken prior to 5.0.

@bhazzard bhazzard added 👍 lgtm and removed triage labels Nov 9, 2023
@linh2931 linh2931 self-assigned this Nov 9, 2023
@linh2931
Copy link
Member

I am able to reproduce this problem in 3.2. Will fix it in 3.2 and merge the fix to 4.0, 5.0, and main.

Will create an integration test in 5.0 and main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👍 lgtm
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants