Migrate index creation from nbdev-index #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jph00 not sure why this one CI test is running for so long. Any ideas? |
Just manually restarted it. |
|
Weird. Seems to be stuck in the same place. I'll merge this and check locally. BTW I think the nb changes you made won't look great in the docs -- maybe you can clean up that a bit so this new functionality has clearer documentation and easier to understand tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the function
create_index, which has been migrated from thenbdev-indexrepo. Additionally, a change was made to this index creation to allow for built-ins to be properly indexed from python's standard lib. However, in order to use this function Sphinx needs to be installed (pip install sphinx). It has been made an optional dependency, but has been added to the dev requirements in order for CI/CD to work. This PR is a dependency for the PR that I have innbdev-index. So, I think the order will matter here - you'll need to merge this one first, and thennbdev-indexwill need to be merged.