New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shouldn't `rnum_methods` and `inum_methods` be set in `fastuple`? #516

Open

fredguth opened this issue Feb 22, 2023 · 0 comments

fredguth commented Feb 22, 2023

Noticed that rnum_methods and inum_methods are exported but never set into fastuple:
https://github.com/fastai/fastcore/blob/f7fea257626106e2016d4a55d280f8b876f6dcb4/fastcore/basics.py#L795

Shouldn't it be:

for n in num_methods + rnum_methods +inum_methods:
    if not hasattr(fastuple, n) and hasattr(operator,n): setattr(fastuple,n,_get_op(n))

?

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment