From 01659ec67c0f325955a3be074cab70671e8fbdda Mon Sep 17 00:00:00 2001
From: Angel Dijoux <77701490+Angel-Dijoux@users.noreply.github.com>
Date: Sat, 30 Dec 2023 17:09:57 +0100
Subject: [PATCH] [Fix] Add refresh token in Onisep API. (#20)

fix: Implement refresh token for oniseop API
---
 src/business_logic/formation/__init__.py      | 17 +++++++++++++----
 .../formation/scrap/utils/get_onisep_data.py  | 13 ++++++++++---
 .../formation/scrap/utils/get_onisep_token.py | 19 +++++++++++--------
 3 files changed, 34 insertions(+), 15 deletions(-)

diff --git a/src/business_logic/formation/__init__.py b/src/business_logic/formation/__init__.py
index b7187e7..7023a4b 100644
--- a/src/business_logic/formation/__init__.py
+++ b/src/business_logic/formation/__init__.py
@@ -1,11 +1,20 @@
+from enum import Enum
 import os
 
-from src.business_logic.formation.scrap.utils.get_onisep_token import get_token
+from src.business_logic.formation.scrap.utils.get_onisep_token import (
+    BearerToken,
+    get_token,
+)
+
+
+class HeaderKey(Enum):
+    APPLICATION_ID = "Application-ID"
+    AUTHORIZATION = "Authorization"
 
 
 ONISEP_URL = "https://api.opendata.onisep.fr/api/1.0/dataset/"
 
-HEADERS = {
-    "Application-ID": os.environ.get("ONISEP_APP_ID"),
-    "Authorization": "Bearer " + get_token(),
+HEADERS: dict[HeaderKey, BearerToken | str] = {
+    HeaderKey.APPLICATION_ID.value: os.environ.get("ONISEP_APP_ID"),
+    HeaderKey.AUTHORIZATION.value: get_token(),
 }
diff --git a/src/business_logic/formation/scrap/utils/get_onisep_data.py b/src/business_logic/formation/scrap/utils/get_onisep_data.py
index 7f2ffe3..4105669 100644
--- a/src/business_logic/formation/scrap/utils/get_onisep_data.py
+++ b/src/business_logic/formation/scrap/utils/get_onisep_data.py
@@ -1,8 +1,10 @@
 # Idéo-Formations initiales en France
 # https://opendata.onisep.fr/data/5fa591127f501/2-ideo-formations-initiales-en-france.htm
 import requests
-from src.business_logic.formation import HEADERS, ONISEP_URL
+from src.business_logic.formation import HEADERS, ONISEP_URL, HeaderKey
 from src.business_logic.formation.exceptions import NoOnisepAPIException
+from src.business_logic.formation.scrap.utils.get_onisep_token import get_token
+from src.constants.http_status_codes import HTTP_200_OK, HTTP_401_UNAUTHORIZED
 
 
 DATASET = "5fa591127f501"
@@ -11,8 +13,13 @@
 def get_onisep_data(params: str) -> dict:
     url = ONISEP_URL + DATASET + params
     response = requests.get(url, headers=HEADERS)
-    if response.status_code == 200:
+    if response.status_code == HTTP_200_OK:
         return response.json()
+    if response.status_code == HTTP_401_UNAUTHORIZED:
+        HEADERS[HeaderKey.AUTHORIZATION.value] = get_token()
+        response = requests.get(url, headers=HEADERS)
+        if response.status_code == HTTP_200_OK:
+            return response.json()
     raise NoOnisepAPIException(
-        f"status: {response.status_code} \n message : Onisep API is down.  \n dataset : {DATASET} \n headers : {HEADERS} "
+        f"\n status: {response.status_code} \n message : Onisep API is down.  \n dataset : {DATASET} \n headers : {HEADERS} "
     )
diff --git a/src/business_logic/formation/scrap/utils/get_onisep_token.py b/src/business_logic/formation/scrap/utils/get_onisep_token.py
index 42d4b02..79013c8 100644
--- a/src/business_logic/formation/scrap/utils/get_onisep_token.py
+++ b/src/business_logic/formation/scrap/utils/get_onisep_token.py
@@ -1,7 +1,9 @@
 import os
-from loguru import logger
+from typing import Literal
 import requests
 
+from src.business_logic.formation.exceptions import NoOnisepAPIException
+
 
 URL = "https://api.opendata.onisep.fr/api/1.0/login"
 
@@ -13,13 +15,14 @@ def _get_form_data() -> dict[str, str]:
     }
 
 
-def get_token() -> str | None:
+BearerToken = Literal["Bearer"]
+
+
+def get_token() -> BearerToken:
     response = requests.post(URL, data=_get_form_data())
     if response.status_code == 200:
         data = response.json()
-        return data.get("token")
-    else:
-        logger.warning(
-            f"Failed to get onisep token. Status code: {response.status_code}"
-        )
-        return None
+        return f"Bearer {data.get('token')}"
+    raise NoOnisepAPIException(
+        f"Failed to get onisep token. Status code: {response.status_code}"
+    )