Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash commands not doing the same things edify does #3

Open
depau opened this issue Sep 15, 2014 · 5 comments
Open

Bash commands not doing the same things edify does #3

depau opened this issue Sep 15, 2014 · 5 comments

Comments

@depau
Copy link

depau commented Sep 15, 2014

The set_perm_recursive and other commands do not do what they're supposed to do in your bash equivalent. I'm quite good at bash, so I can fix them for you and PR, but I can't find the code... can you point it out to me?

Thanks!

Oh, by the way, some zips don't use the updater-script but replace the update-binary with a shell script to be able to perform more operations. You should check whether it's a binary or a text file. Some other zips have Aroma, which is definitely not compatible with this app unless you make an aroma interpreter with a GUI (which I'm not going to help you with, not enough free time...)

@depau depau changed the title Commands not corresponding Bash commands not doing the same things edify does Sep 15, 2014
@Androguide
Copy link
Owner

Thanks for your time and for the suggestions.
I haven't worked on this project in a while, but the code which handles the translation between edify and bash is all in EdifyParser.java

@depau
Copy link
Author

depau commented Sep 19, 2014

Hmm, I why didn't you use Java methods directly then? I mean, it's
easier and safer against code injection. I thought you did something
like running a bash script that imported some bash library with the
edify functions then imported the edify script...
I can make something like that, but not at the moment. I think I'll add
a reminder on my phone for a week from today so that I don't forget
about it.

I can't program Java, so I can't help you with the app.

On 09/19/2014 03:24 PM, Louis Teboul wrote:

Thanks for your time and for the suggestions.
I haven't worked on this project in a while, but the code which
handles the translation between edify and bash is all in
EdifyParser.java
https://github.com/Androguide/FlashGordon/blob/master/src/com/androguide/recovery/emulator/helpers/EdifyParser.java


Reply to this email directly or view it on GitHub
#3 (comment).

@Androguide
Copy link
Owner

There are no Java API for working with edify, this is done by the recovery, which is written in C/C++.
I've been told you can execute the update-binary directly from the OS through bash if you pass the right arguments though, but I never looked into it.

@depau
Copy link
Author

depau commented Sep 19, 2014

I mean, instead of using external programs to set permissions, etc, you can just use the java equivalent. As I said I don't know what they are as I don't know Java, but I'm pretty sure you can do that.

You may be able to run something like "recovery <script>", but I think it checks the signature by default.

@syaravanaa73
Copy link

Hio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants