Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eosslgbackup] code review report #12

Open
yukiexe opened this issue Sep 16, 2018 · 0 comments
Open

[eosslgbackup] code review report #12

yukiexe opened this issue Sep 16, 2018 · 0 comments

Comments

@yukiexe
Copy link
Member

yukiexe commented Sep 16, 2018

  • 缺乏 README.md
    需要更新 README.md 再 review 一次
    README.md 中需要這份合約的用途、 abi actions 的項目和說明

  • 缺乏 /// @abi action
    沒有標記 @abi action ,雖然abi 產出出來是對的,但是還是加一下比較好,方便其他人看

  • // @abi table card i64
    這個 table 不應該叫做 card ,這是給 abi 生成器設定 table 名字的參數

  • struct player {
    --> account_name account;
    asset balance;
    --> uint64_t primary_key() const { return account; }
    EOSLIB_SERIALIZE(player, (account)(balance))
    };

傳回類型不一致,會導致隱式轉換;建議改成 auto ,並且回顧相關 code 的正確性
又由於加了 // @abi table card i64 會強制設定 index_type 為 i64
架構改成加上 uint64_t id 做為 primary_key 會比較妥當

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant