Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue at Performing statistical tests stage #3

Open
sgsutcliffe opened this issue Apr 13, 2021 · 5 comments
Open

Issue at Performing statistical tests stage #3

sgsutcliffe opened this issue Apr 13, 2021 · 5 comments

Comments

@sgsutcliffe
Copy link

At the statistical stage I am getting the error:

"statistics.StatisticsError: mean requires at least one data point"

It comes from line 758
avg_h = statistics.mean(cov_h)

I think it's because I am working with a dataset you probably hadn't expected. I've concatenated multiple prophages, and this leads to prophages that span the entire scaffold. So I guess that would have host-coverage of 0?

Is this the issue?

@sgsutcliffe
Copy link
Author

I was thinking about this issue, would it be worthwhile to use the entire genome as host coverage predictor rather than the scaffolds when you have contiguous genomes? I know coverage can vary over the genome/scaffolds but would help with my previous problem.
When possible I think using your current approach is better though. :)

@KrisKieft
Copy link
Member

Hi,

I'm not sure how I missed this post. I just now saw it and I'm sorry about that!

Yes, sounds like the host had 0 data points so PropagAtE was trying to compare the prophage to nothing. I should add an exception to avoid the error. For your second post you make a good argument, but PropagAtE was created for metagenomic data in which the entire host genome cannot be accurately identified. Even with binning a MAG there will be multiple scaffolds (likely) that are contamination and may alter the coverage results. It is more accurate to consider only the parent scaffold of the prophage. I will consider adding an option to specify an entire MAG though I wouldn't count on that being implemented.

@sgsutcliffe
Copy link
Author

Thanks for the reply!

Since making the post I've come around to the idea that relying using prophages without flanking-host regions is bad or at least risky. This paper highlights the issue of 'miss-binning' prophages when bacterial MAGs are closely related: https://doi.org/10.1038/s41587-020-0718-6

@KrisKieft
Copy link
Member

I agree. Great group to rely on who wrote that paper. I have a manuscript coming out in ~1 week regarding viral binning, including a couple points on binning prophages. Self promotion :) but also it may be of interest when available.

@sgsutcliffe
Copy link
Author

sgsutcliffe commented Dec 2, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants