Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toc-entry: move label/title logic to label.js #398

Closed
pkra opened this issue Nov 23, 2022 · 2 comments
Closed

toc-entry: move label/title logic to label.js #398

pkra opened this issue Nov 23, 2022 · 2 comments
Labels
Milestone

Comments

@pkra
Copy link
Member

pkra commented Nov 23, 2022

toc-entry handles label/title instead of relying on label.js.

We should move the code over.

@pkra
Copy link
Member Author

pkra commented Nov 23, 2022

label.js deserves some refactoring though.

pkra added a commit that referenced this issue Nov 23, 2022
Replaces TODO with NOTE pointing to #398.

Part of #289
@pkra pkra added this to the 2023 milestone Jan 19, 2023
@pkra pkra modified the milestones: 2023, 2024 Jan 15, 2024
@pkra
Copy link
Member Author

pkra commented Jul 4, 2024

A few years later, I'm leaning the other way #452

@pkra pkra closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2024
@pkra pkra added wontfix and removed maintenance labels Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant