Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional activity log types #1588

Open
2 tasks done
Tracked by #1138
elsand opened this issue Dec 11, 2024 · 0 comments
Open
2 tasks done
Tracked by #1138

Add additional activity log types #1588

elsand opened this issue Dec 11, 2024 · 0 comments
Assignees

Comments

@elsand
Copy link
Member

elsand commented Dec 11, 2024

Introduction

To better support Altinn 3, we need to add additional activity types to the enum

Description

These should be added. They should all have the same validation ie. "DialogCreated" (ie not allow description nor transmissionId to be set)

DialogDeleted
DialogRestored
SentToSigning
SentToFormFill
SentToSendIn
SentToPayment

Tasks

Preview Give feedback

Threat modelling

Preview Give feedback

Acceptance criteria

GIVEN that the new activity types (DialogDeleted, DialogRestored, SentToSigning, SentToFormFill, SentToSendIn, SentToPayment) have been added to the enum
WHEN an service provider client attempts to create an activity with one of these new types
THEN the system must successfully accept and store the new activity type in the database
AND any attempt to include description or transmissionId fields for these activity types must be rejected (similar to the DialogCreated validation)

GIVEN that an activity of type DialogDeleted, DialogRestored, SentToSigning, SentToFormFill, SentToSendIn or SentToPayment exists in the database
WHEN the activity is retrieved through an API call
THEN the response must correctly return the new activity type
AND the fields description and transmissionId must not be present

@elsand elsand moved this from Backlog to Ready in Dialogporten / Arbeidsflate - GAMMEL Dec 11, 2024
@oskogstad oskogstad self-assigned this Dec 22, 2024
@oskogstad oskogstad moved this from Ready to Doing in Dialogporten / Arbeidsflate - GAMMEL Dec 22, 2024
@oskogstad oskogstad moved this from Doing to Code Review og PR in Dialogporten / Arbeidsflate - GAMMEL Dec 24, 2024
oskogstad added a commit that referenced this issue Jan 6, 2025
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

## Related Issue(s)

- #1588 

## Verification

- [x] **Your** code builds clean without any errors or warnings
- [x] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)
@elsand elsand moved this to Code Review og PR in Dialogporten / Arbeidsflate - NY Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Code Review og PR
Development

No branches or pull requests

2 participants