Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting a valid layoutset name results in an error #13689

Closed
mlqn opened this issue Oct 3, 2024 · 2 comments · Fixed by #14327
Closed

Submitting a valid layoutset name results in an error #13689

mlqn opened this issue Oct 3, 2024 · 2 comments · Fixed by #14327
Assignees
Labels
kind/bug Used when there is a defect / something is not working as it should. status/ready-for-specification Status: Used for issues that are ready for functional decription og detailed design. team/studio-domain1 team/studio-domain2

Comments

@mlqn
Copy link
Contributor

mlqn commented Oct 3, 2024

Description of the bug

Submitting a valid layoutset name results in an error, pointing to a potential flaw in the validation logic

Steps To Reproduce

Process editor

name_validation_process.mov

Ui editor

name_validation_ui.mov

Additional Information

No response

@mlqn mlqn added kind/bug Used when there is a defect / something is not working as it should. status/triage labels Oct 3, 2024
@mlqn mlqn changed the title Submitting a valid layoutset name results in an error on the process editor Submitting a valid layoutset name results in an error Oct 3, 2024
@mlqn mlqn added team/studio-domain2 status/ready-for-specification Status: Used for issues that are ready for functional decription og detailed design. and removed status/triage labels Oct 3, 2024
@nkylstad
Copy link
Member

Yep, seems like we should take a look at our validation regex here. I suggest some restrictions:

  • Must start with at least 1 character in [a-z,A-Z]
  • Can only contain characters [a-z,A-Z,0-9] and potentially -.

@nkylstad
Copy link
Member

nkylstad commented Dec 16, 2024

We have made some changes to the regex here, check if this is already solved. Or check if backend has a stricter check that we have not implemented in frontend.

@Konrad-Simso Konrad-Simso moved this to 📈 Todo in Team Studio Dec 16, 2024
@standeren standeren self-assigned this Dec 23, 2024
@standeren standeren moved this from 📈 Todo to 👷 In Progress in Team Studio Dec 23, 2024
@standeren standeren linked a pull request Dec 23, 2024 that will close this issue
3 tasks
@github-project-automation github-project-automation bot moved this from 👷 In Progress to Documentation in Team Studio Jan 8, 2025
@standeren standeren moved this from Documentation to ✅ Done in Team Studio Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Used when there is a defect / something is not working as it should. status/ready-for-specification Status: Used for issues that are ready for functional decription og detailed design. team/studio-domain1 team/studio-domain2
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants