Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forenkling av miljøvariabler som ikke er hemmeligheter #565

Open
Ceredron opened this issue Jan 2, 2025 · 0 comments
Open

Forenkling av miljøvariabler som ikke er hemmeligheter #565

Ceredron opened this issue Jan 2, 2025 · 0 comments
Labels
kind/chore changes that do not relate to a fix or feature and don't modify src or test files

Comments

@Ceredron
Copy link
Collaborator

Ceredron commented Jan 2, 2025

Beskrivelse
Vi har ikke noe godt mønster for miljøvariabler som egentlig ikke er hemmelige. De legges inn som Github secrets som alle andre, men det vil være lettere for alle om de ikke legges inn som secrets (bl.a for eventuell debugging). Vi bør finne et bedre mønster for disse verdiene. Kan kanskje bruke ENVIRONMENT variabelen for å sette de.

Dette gjelder:
CONTACT_RESERVATION_REGISTRY_BASE_URL
PLATFORM_BASE_URL
DIALOGPORTEN_ISSUER
CORRESPONDENCE_BASE_URL

Muligens:
LEGACY_BASE_URL
MASKINPORTEN_TOKEN_EXCHANGE_ENVIRONMENT
@Ceredron Ceredron converted this from a draft issue Jan 2, 2025
@Ceredron Ceredron added the kind/chore changes that do not relate to a fix or feature and don't modify src or test files label Jan 2, 2025
@Ceredron Ceredron mentioned this issue Jan 2, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/chore changes that do not relate to a fix or feature and don't modify src or test files
Projects
Altinn melding og formidling
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ceredron