Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code to put window as a desktop on x11 and to detect/set screen resolution #62

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

bigbadbob2003
Copy link

No description provided.

@Almamu
Copy link
Owner

Almamu commented Dec 4, 2021

Hi @bigbadbob2003

I've tested the changes you've made but I can't really figure out exactly how it's supposed to work. Regardless of running with --screen-root switches or not, I get a normal window that doesn't go to the background (I'm using i3 with picom). I guess you've tested it with some specific desktop environment? Could you add some extra information so I can actually test it?

I cannot merge it as is, but we can build upon this code and make it work when the situation is right if it's working on any of the desktop environments.

@bigbadbob2003
Copy link
Author

Hi @Almamu

Interesting there is obviously more involved to cover all DE's, i'm using budgie desktop environment with budgie desktop view.

I had no luck with the the screen-root switch which is why i have gone down the route i have, I looked into the way conky recommends putting widgets into the background and having them static across virtual desktops.

When i run it after the changes i made it goes fully into the background behind my desktop icons and static conky widgets, like this:

image

@Almamu
Copy link
Owner

Almamu commented Dec 4, 2021

I'm guessing that i3 is doing something special with that window and that's why I see it as a normal one that I can move :/ (maybe the window needs some extra hints or something?)

The --screen-root switch is the mechanism the app should follow to select what screen you want to draw the background to, so before merging this pull request the code should at least take that into account.

There's of course some extra work required (like detecting when to use this method and when to use the old one, or a way to make this method work on everything else), but If this one works on more DEs that the one I already implemented that'd be a nice progress.

@Almamu Almamu force-pushed the main branch 8 times, most recently from 2d8ff42 to 17d4be6 Compare March 11, 2022 11:33
@Almamu Almamu force-pushed the main branch 2 times, most recently from ffa6932 to 28f0868 Compare May 8, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants