New software daytime overlays

[BobW55]

Had some trouble getting FTP to work. Not sure what I did or didn't do but working now.
Overlays were working great at night but during day have gone away. Link to my image.
http://melvinweather.com/allsky/allsky.jpg
Trying to dial in my daytime settings and some of the overlay information was very helpful. I am not sure what I changed for it to go away.
Stopping the Allsky service and rebooting the Pi did not help.

[EricClaeys]

@BobW55 are you using the new version that we are testing, and if so, are you using the new overlay module? If so, @Alex-developer can answer your overlay question.

[BobW55]

Yes new version Yes was working with night time.

…

On Tue, Dec 27, 2022, 1:02 PM EricClaeys ***@***.***> wrote: @BobW55 <https://github.com/BobW55> are you using the new version that we are testing, and if so, are you using the new overlay module? If so, @Alex-developer <https://github.com/Alex-developer> can answer your overlay question. — Reply to this email directly, view it on GitHub <#2061 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4JBJ27Q65B7A4FNLRDAGPDWPMVLBANCNFSM6AAAAAATKRVNLA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[EricClaeys]

@BobW55 check the list of modules that run during the day. You may need to include or enable the Overlay module.

[Alex-developer]

@BobW55 Can you check the error log for the daytime captures. The file is /var/log/allsky.log

I suspect there is an error being thrown OR check that the overlay is active for daytime captures, goto the 'Module Editor' and select 'Daytime'. Then check the overlay module is active.

Cheers

Alex

[BobW55]

It is enabled. I even tried turning it off, saving, then turning it back on.

[Alex-developer]

Anything in the error logs?

[BobW55]

Dec 27 14:42:14 allsky1 allsky.sh[25299]: INFO: Module allsky_loadimage.py ran ok in 64.879ms
Dec 27 14:42:14 allsky1 allsky.sh[25299]: INFO: ----------------------- Running Module allsky_export.py --------------->Dec 27 14:42:14 allsky1 allsky.sh[25299]: INFO: Attempting to load allsky_export
Dec 27 14:42:14 allsky1 allsky.sh[25299]: INFO: Allsky data exported to /home/pi/allsky/tmp/allskydata.json
Dec 27 14:42:14 allsky1 allsky.sh[25299]: INFO: Module allsky_export.py ran ok in 3.2929999999999997ms
Dec 27 14:42:14 allsky1 allsky.sh[25299]: INFO: ----------------------- Running Module allsky_maskimage.py ------------>Dec 27 14:42:14 allsky1 allsky.sh[25299]: INFO: Attempting to load allsky_maskimage
Dec 27 14:42:14 allsky1 allsky.sh[25299]: ERROR: No mask defined
Dec 27 14:42:14 allsky1 allsky.sh[25299]: INFO: Module allsky_maskimage.py ran ok in 0.045000000000000005ms
Dec 27 14:42:14 allsky1 allsky.sh[25299]: INFO: ----------------------- Running Module allsky_overlay.py -------------->Dec 27 14:42:14 allsky1 allsky.sh[25299]: INFO: Attempting to load allsky_overlay
Dec 27 14:42:14 allsky1 allsky.sh[25299]: Traceback (most recent call last):
Dec 27 14:42:14 allsky1 allsky.sh[25299]:   File "/home/pi/allsky/scripts/flow-runner.py", line 174, in <module>
Dec 27 14:42:14 allsky1 allsky.sh[25299]:     result = globals()[method](arguments, shared.args.event)
Dec 27 14:42:14 allsky1 allsky.sh[25299]:   File "/home/pi/allsky/scripts/allsky_overlay.py", line 1040, in overlay
Dec 27 14:42:14 allsky1 allsky.sh[25299]:     annotater.annotate()
Dec 27 14:42:14 allsky1 allsky.sh[25299]:   File "/home/pi/allsky/scripts/allsky_overlay.py", line 1010, in annotate
Dec 27 14:42:14 allsky1 allsky.sh[25299]:     if self._initialiseMoon():
Dec 27 14:42:14 allsky1 allsky.sh[25299]:   File "/home/pi/allsky/scripts/allsky_overlay.py", line 783, in _initialiseM>Dec 27 14:42:14 allsky1 allsky.sh[25299]:     symbol = chr(ord('A')+s.int(symbol+0.5)-1)
Dec 27 14:42:14 allsky1 allsky.sh[25299]:   File "/home/pi/allsky/scripts/modules/allsky_shared.py", line 368, in int
Dec 27 14:42:14 allsky1 allsky.sh[25299]:     val = locale.atoi(val)
Dec 27 14:42:14 allsky1 allsky.sh[25299]:   File "/usr/lib/python3.9/locale.py", line 332, in atoi
Dec 27 14:42:14 allsky1 allsky.sh[25299]:     return int(delocalize(string))
Dec 27 14:42:14 allsky1 allsky.sh[25299]: ValueError: invalid literal for int() with base 10: '4.19513089247'

How to I copy the log file to here?

[Alex-developer]

Bob

Edit /home/pi/allsky/scripts/allsky_overlay.py and delete the s. The line should then read

symbol = chr(ord('A')+int(symbol+0.5)-1)

Be careful NOT to change the indenting or it will break totally !

Also if line 810 has the s. then remove the s. as well

I have already fixed this issue so any re install will not have the problem

Cheers

Alex

[BobW55]

Line 783 now =

 symbol = chr(ord('A')+.int(symbol+0.5)-1)

line 810 =

fileModifiedTime = .int(os.path.getmtime(fileName))

[Alex-developer]

Take the full stop out as well

[BobW55]

Full Stop?
Sorry... noob here

[BobW55]

FIXED......
had to take the . out

[BobW55]

symbol = chr(ord('A')+int(symbol+0.5)-1)

 fileModifiedTime = int(os.path.getmtime(fileName))

[EricClaeys]

@Alex-developer. Alex, would it be possible for modules like the mask one to not allow enabling them until a mask is defined?
Ditto for other modules that won't work until the user configures them?
I think that will decrease frustration and support calls.

Eric

[BobW55]

I also found it confusing that I had to drag the module to the right to use it, but could still enable or diasable it on the right side.

[Alex-developer]

@BobW55 The idea behind it was that you can only set the configuration for a module once its been dragged to the right column, this is to allow for a feature thats not been implemented yet where you can have multiple instances of the same module running.

So once a module is dragged to the 'enabled column' the enable/disable option allows you to enable/disable it without losing its config.

[BobW55]

OK makes sense, but still confusing because you can click enable while is is on the left side, yes you can only configure it on the right.

[Alex-developer]

@EricClaeys I'll have a look. All of the modules I have written will log and issues to do with their config, for example I added the 'Mask Image' module but didn't specify a mask. The results in the allsky log file

Dec 27 23:38:59 allskydev allsky.sh[10698]: INFO: ----------------------- Running Module allsky_maskimage.py -----------------------
Dec 27 23:38:59 allskydev allsky.sh[10698]: INFO: Attempting to load allsky_maskimage
Dec 27 23:38:59 allskydev allsky.sh[10698]: ERROR: No mask defined
Dec 27 23:38:59 allskydev allsky.sh[10698]: INFO: Module allsky_maskimage.py ran ok in 0.027ms

Its far from ideal as it does need the debug level set to 4 and an understanding of how to view the log file.

The module configs are all built from the metaData variable so I can probably add some validation logic to this, I added the fields for this when I first defined the meta data but never implemented it

So for example in the mask module the current metaData looks like this

metaData = {
    "name": "Mask Image",
    "description": "Masks an Image",
    "events": [
        "day",
        "night"
    ],
    "arguments":{
        "mask": ""
    },    
    "argumentdetails": {
        "mask" : {
            "required": "false",
            "description": "Mask Path",
            "help": "The name of the image mask",
            "type": {
                "fieldtype": "image"
            }                
        } 
    }         
}

So if I implement the 'required' field this will help with some fields. I will have a think about some more complex validation options, i.e. field a is dependent on field b

Cheers

Alex