Move keogram date to right of midnight line

[pablo-blake]

Hello,
``
Although I've been using allsky for almost a year, I just noticed that the date added to keogram images represents the date after midnight... however, the date is placed to the left of midnight line. Below is the update I made to keogram.cpp to move the date to the right of the midnight.

Update removes 'textSize.width' shift (left) in date txt (below '// Draw date' in code).

                            if (ann->at<int>(r, 0) - textSize.width >= 0) {
                                    // black background
                                    cv::putText(*acc, text,
                                            //cv::Point(ann->at<int>(r, 0) - textSize.width,
                                            cv::Point(ann->at<int>(r, 0),
                                            acc->rows - (2.5 * textSize.height)),
                                            cf->fontFace, cf->fontScale,
                                            cv::Scalar(0, 0, 0), cf->lineWidth+2,
                                            cf->fontType);
                                    // Text
                                    cv::putText(*acc, text,
                                            //cv::Point(ann->at<int>(r, 0) - textSize.width,
                                            cv::Point(ann->at<int>(r, 0),
                                            acc->rows - (2.5 * textSize.height)),
                                            cf->fontFace, cf->fontScale,
                                            cv::Scalar(cf->b, cf->g, cf->r), cf->lineWidth,
                                            cf->fontType);
                            }

Just an FYI, Paul

[EricClaeys]

@pablo-blake Paul, thanks for the suggestion. After thinking about it, I'm wondering if the date should be when the keogram started, not when it ended. If so, it would remain on the left side of midnight but be a day earlier than it currently shows.

Looking at the code's comments, it's supposed to be "at location of 0 hours, or right justified", so I think the current behavior is a bug.

@Alex-developer, your thoughts?

[pablo-blake]

Hi Eric,

I did a quick look thru the code (keogram.cpp) for comments, but did see anything regarding 'date justification', only...
// Draw date
Maybe i missed what you located.

There is a comment on hour txt labels...
// Draw text label to the left of the dash
It uses the same logic, as date, for justification:
cv::Point(ann->at(r, 0) - textSize.width,

I'm OK w/the fix I made on my pi. However, as you indicated, leaving justification to the left of 00 hr and using the date the keogram started also works. ...I'm not a cpp programer, so removing the offset seemed simpler. Looks like date comes from 'text(time_buf)'. Guessing this might be from a system date-time call?

Take care, Paul

[Alex-developer]

@pablo-blake Paul, thanks for the suggestion. After thinking about it, I'm wondering if the date should be when the keogram started, not when it ended. If so, it would remain on the left side of midnight but be a day earlier than it currently shows.

Looking at the code's comments, it's supposed to be "at location of 0 hours, or right justified", so I think the current behavior is a bug.

@Alex-developer, your thoughts?

There are really two dates here are there not? The day the Keogram starts and the date after midnight

I would be inclined to make it a series of settings rather than hard code it something like;

• Show at start
• Show at midnight

Also a setting to set the date format as its a little long

[EricClaeys]

How about if in the next release we add an option to keogram to specific the date should be the start of the keogram, or the end of the keogram? If the start, the date would be left justified; if the end, it would be right justified.
For someone who lives very far north or south, their daytime might begin after midnight, so their "start" and "after midnight dates would be the same. I prefer not to use midnight for any calculations.

I can also look at adding an option to format the date, but other than using 2-character year, I'm not sure anyone will use a shorter date than 12-20-22, although for internationalization purposes we need to allow non-US formats.

Comments?

[Alex-developer]

Sounds good to me :-)

[pablo-blake]

Hi Eric,

Seems the least complicated update, for now, is to move the date to the right of midnight line. This provides an accurate date location on the annotated image.
Allowing user customization is always useful, as long default configs will function for most users w/o intervention.

For me, using YY can lead to an incorrect interpretation of date formats. I typically prefer YYYY-MM-DD - always sorts chronologically and reduces ambiguity.