Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle TIMED_OUT job event #19

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Handle TIMED_OUT job event #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed29ad4
Handle TIMED_OUT job event
Oct 31, 2023
072ccc0
Fix github actions for windows
Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 40 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,49 @@ on:
pull_request:
branches: [ main ]
jobs:
tests:
tests-ubuntu:
name: tests-python${{ matrix.python-version }}-${{ matrix.os }}
runs-on: ${{ matrix.os }}
strategy:
matrix:
python-version: [3.7, 3.8, 3.9, '3.10']
os: ["macOS-latest", "ubuntu-latest", "windows-latest"]
python-version: ['3.7', '3.8', '3.9', '3.10']
os: ["ubuntu-latest"]
steps:
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Install Deps
run: make install
- name: Install and Run Tests
run: make unit-tests
tests-macOS:
name: tests-python${{ matrix.python-version }}-${{ matrix.os }}
runs-on: ${{ matrix.os }}
strategy:
matrix:
python-version: ['3.7', '3.8', '3.9', '3.10']
os: ["macOS-latest"]
steps:
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Install Deps
run: make install
- name: Install and Run Tests
run: make unit-tests
tests-windows:
name: tests-python${{ matrix.python-version }}-${{ matrix.os }}
runs-on: ${{ matrix.os }}
strategy:
matrix:
# We skip Python 3.7 has Windows needs to rebuild it, but its specs are
# too low to do it...
python-version: ['3.8', '3.9', '3.10']
os: ["windows-latest"]
steps:
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
Expand Down Expand Up @@ -49,7 +85,7 @@ jobs:
- name: Set up Python 3.9
uses: actions/setup-python@v4
with:
python-version: 3.9
python-version: '3.9'
- name: Install Deps
run: make install
- name: Run lint
Expand Down
11 changes: 8 additions & 3 deletions qiskit_alice_bob_provider/remote/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
##############################################################################

import csv
import logging
from dataclasses import dataclass
from io import StringIO
from typing import Callable, Dict, Optional
Expand All @@ -30,7 +31,6 @@
QobjExperimentHeader,
)

from ..errors import AliceBobException
from .api import jobs
from .api.client import ApiClient

Expand Down Expand Up @@ -214,12 +214,17 @@ def _ab_event_to_qiskit_status(event: str) -> JobStatus:
'COMPILATION_FAILED',
'TRANSPILATION_FAILED',
'EXECUTION_FAILED',
'TIMED_OUT',
}:
return JobStatus.ERROR
elif event == 'SUCCEEDED':
return JobStatus.DONE
elif event == 'CANCELLED':
return JobStatus.CANCELLED
raise AliceBobException(
f'Received unexpected job event "{event}" from Alice & Bob\'s API'
logging.warning(
f'Received unexpected job event {event}. \n'
'Please ensure you are running the latest version of the Alice & Bob '
'Provider .'
)
# An unknown job status will be considered to be an Error by default.
return JobStatus.ERROR