From 6951f13c0991bd89a2988d13f9329e7612523762 Mon Sep 17 00:00:00 2001 From: AlexWaygood Date: Mon, 16 Oct 2023 13:57:27 +0100 Subject: [PATCH] gh-110923: Don't silently skip tests in `test__opcode.py` --- Lib/test/.ruff.toml | 1 - Lib/test/test__opcode.py | 10 +++++++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/Lib/test/.ruff.toml b/Lib/test/.ruff.toml index 329a3b4fba6b5b..ed108550fbf6cc 100644 --- a/Lib/test/.ruff.toml +++ b/Lib/test/.ruff.toml @@ -11,7 +11,6 @@ extend-exclude = [ "encoded_modules/module_iso_8859_1.py", "encoded_modules/module_koi8_r.py", # TODO Fix: F811 Redefinition of unused name - "test__opcode.py", "test_buffer.py", "test_ctypes/test_arrays.py", "test_ctypes/test_functions.py", diff --git a/Lib/test/test__opcode.py b/Lib/test/test__opcode.py index c1f612dc4a63cb..10f04b64dda40e 100644 --- a/Lib/test/test__opcode.py +++ b/Lib/test/test__opcode.py @@ -8,6 +8,14 @@ class OpListTests(unittest.TestCase): + def check_bool_function_result(self, func, ops, expected): + for op in ops: + if isinstance(op, str): + op = dis.opmap[op] + with self.subTest(opcode=op, func=func): + self.assertIsInstance(func(op), bool) + self.assertEqual(func(op), expected) + def test_invalid_opcodes(self): invalid = [-100, -1, 255, 512, 513, 1000] self.check_bool_function_result(_opcode.is_valid, invalid, False) @@ -47,7 +55,7 @@ def check_function(self, func, expected): check_function(self, _opcode.has_exc, dis.hasexc) -class OpListTests(unittest.TestCase): +class StackEffectTests(unittest.TestCase): def test_stack_effect(self): self.assertEqual(stack_effect(dis.opmap['POP_TOP']), -1) self.assertEqual(stack_effect(dis.opmap['BUILD_SLICE'], 0), -1)